Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BaseValidator.describe #267

Merged
merged 2 commits into from
May 8, 2023
Merged

feat: add BaseValidator.describe #267

merged 2 commits into from
May 8, 2023

Conversation

imranbarbhuiya
Copy link
Contributor

@imranbarbhuiya imranbarbhuiya marked this pull request as ready for review May 8, 2023 04:58
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5e73733) 99.27% compared to head (371592a) 99.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #267   +/-   ##
=======================================
  Coverage   99.27%   99.28%           
=======================================
  Files          58       58           
  Lines        3470     3477    +7     
  Branches      712      713    +1     
=======================================
+ Hits         3445     3452    +7     
  Misses         17       17           
  Partials        8        8           
Flag Coverage Δ
16 99.28% <100.00%> (+<0.01%) ⬆️
18 99.28% <100.00%> (+<0.01%) ⬆️
19 99.28% <100.00%> (+<0.01%) ⬆️
20 99.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/validators/BaseValidator.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@favna favna changed the title chore: add describe feat: add BaseValidator.describe May 8, 2023
@favna favna merged commit d9e1a2d into sapphiredev:main May 8, 2023
@imranbarbhuiya imranbarbhuiya deleted the feat/describe branch May 8, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants