add CMP0063 policy #101

etodanik · 2023-10-11T13:18:43Z

3.27.7 started actively warning if CMP0063 isn't set, which pollutes a project depending on plibsys with a lot of warnings.

saprykin · 2023-10-11T20:32:07Z

Could you please provide conditions under which you get these warnings? Operating system and compiler with versions, and CMake options you use to configure?

etodanik · 2023-10-11T20:33:23Z

Any OS, compiler doesn't matter as it's a CMake issue, CMake 3.27.7:
https://cmake.org/cmake/help/latest/policy/CMP0063.html

It will show a warning any time the policy isn't set.

saprykin · 2023-10-11T20:58:49Z

Just checked it on macOS with clang 14 and gcc 12, CMake 3.27.7, no warnings in both cases. Do you change visibility properties of any targets?

etodanik · 2023-10-11T21:00:22Z

Did you try to embed this in a larger project with varying visibility settings? plibsys can easily exist as a dependency, in which case this setting becomes relevant.

…

On Wed, Oct 11, 2023 at 23:59 Alexander Saprykin ***@***.***> wrote: Just checked it on macOS with clang 14 and gcc 12, CMake 3.27.7, no warnings in both cases. Do you change visibility properties of any targets? — Reply to this email directly, view it on GitHub <#101 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPBB6CJTSGNS45MSLH6PXDX64CBHANCNFSM6AAAAAA537UYRQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

saprykin · 2023-10-11T21:25:35Z

If you use plibsys as a dependency (sub project) and vary global visibility settings, why don’t you set this policy at the top level as well? Policies should propagate to sub projects in CMake. The only reason for a top-level policy being not propagated could be minimum CMake version < 3.3 specified. Let me check this case.

etodanik · 2023-10-11T21:26:45Z

In my case it didn’t propagate

…

On Thu, Oct 12, 2023 at 00:25 Alexander Saprykin ***@***.***> wrote: If you use plibsys as a dependency (sub project) and vary global visibility settings, why don’t you set this policy at the top level as well? Policies should propagate to sub projects in CMake. The only reason for a top-level policy being not propagated could be minimum CMake version < 3.3 specified. Let me check this case. — Reply to this email directly, view it on GitHub <#101 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPBB6H6KEEGM6TV7NMK7WLX64FFTANCNFSM6AAAAAA537UYRQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

saprykin · 2023-10-11T23:34:04Z

How do you include plibsys as dependency and which version/commit of plibsys do you use? Policy CMP0063 was introduced back in CMake 3.3, and it warns since then (not only since 3.27.7). However, top-level CMakeLists.txt of plibsys contains the following line:
cmake_minimum_required (VERSION 2.8.0...3.25.1)
This directive already sets CMP0063 policy to NEW, as well as others. Hence, it cannot produce warnings unless you lower minimum required CMake below 3.3. In case required CMake is below 3.3 and global visibility settings are modified through, i.e. CMAKE_C_VISIBILITY_PRESET variable, then I'm able to reproduce the warnings.