-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eslint to version 3.0.0 🚀 #119
Conversation
Current coverage is 100%@@ master #119 diff @@
====================================
Files 9 9
Lines 206 206
Methods 0 0
Messages 0 0
Branches 0 0
====================================
Hits 206 206
Misses 0 0
Partials 0 0
|
@sarbbottam when can this be released? |
@sarbbottam we should change |
@ljharb can you make a PR with my proposed change? I could merge it when all tests pass, but not make a PR myself right now ... |
@ta2edchimp @sarbbottam i would highly discourage making a peer dep range blindly include new major versions. The proper thing to do is to manually update it every time a new major version is updated. |
I guess you're right. @sarbbottam Nevertheless, we should look if we could somehow automate this (update |
Well, or just do it manually for major releases of eslint, nvm ... |
Sorry for the late response, traveling with family, long weekend ... Does #121 addresse the need? |
Hello lovely humans,
eslint just published its new version 3.0.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of eslint.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
GitHub Release
require-yield
rule toeslint:recommended
(fixes #6550) (#6554) (Gyandeep Singh)no-regex-spaces
(fixes #3586) (#6379) (Jackson Ray Hamilton)no-unused-vars
ignores read it modifies itself (fixes #6348) (#6535) (Toru Nagashima)no-useless-rename
(fixes #6502) (#6506) (Toru Nagashima)meta
for"eslint:recommended"
(refs #6403) (#6539) (Mark Pedrotti)object-shorthand
(fixes #6429) (#6434) (Toru Nagashima)strict
rule reports a syntax error for ES2016 (fixes #6405) (#6464) (Toru Nagashima)no-duplicate-imports
(#6463) (Simen Bekkhus)no-native-reassign
and specifying globals (fixes #5358) (#6462) (Toru Nagashima)The new version differs by 41 commits .
5ec54be
3.0.0
6f49c1e
Build: package.json and changelog update for 3.0.0
66de9d8
Docs: Update installation instructions on README (#6569)
dc5b78b
Breaking: Add
require-yield
rule toeslint:recommended
(fixes #6550) (#6554)7988427
Fix: lib/config.js tests pass if personal config exists (fixes #6559) (#6566)
4c05967
Docs: Update rule docs for new format (fixes #5417) (#6551)
70da5a8
Docs: Correct link to rules page (#fixes 6553) (#6561)
e2b2030
Update: Check RegExp strings for
no-regex-spaces
(fixes #3586) (#6379)397e51b
Update: Implement outerIIFEBody for indent rule (fixes #6259) (#6382)
666da7c
Docs: 3.0.0 migration guide (#6521)
b9bf8fb
Docs: Update Governance Policy (fixes #6452) (#6522)
1290657
Update:
no-unused-vars
ignores read it modifies itself (fixes #6348) (#6535)d601f6b
Fix: Delete cache only when executing on files (fixes #6459) (#6540)
e0d4b19
Breaking: Error thrown/printed if no config found (fixes #5987) (#6538)
18663d4
Fix: false negative of
no-useless-rename
(fixes #6502) (#6506)There are 41 commits in total. See the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? ⚡
greenkeeper upgrade