Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint to version 3.0.0 🚀 #119

Merged
merged 1 commit into from
Jul 2, 2016
Merged

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello lovely humans,

eslint just published its new version 3.0.0.

State Update 🚀
Dependency eslint
New version 3.0.0
Type devDependency

This version is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of eslint.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


GitHub Release

  • 66de9d8 Docs: Update installation instructions on README (#6569) (Nicholas C. Zakas)
  • dc5b78b Breaking: Add require-yield rule to eslint:recommended (fixes #6550) (#6554) (Gyandeep Singh)
  • 7988427 Fix: lib/config.js tests pass if personal config exists (fixes #6559) (#6566) (Kevin Partington)
  • 4c05967 Docs: Update rule docs for new format (fixes #5417) (#6551) (Nicholas C. Zakas)
  • 70da5a8 Docs: Correct link to rules page (#fixes 6553) (#6561) (alberto)
  • e2b2030 Update: Check RegExp strings for no-regex-spaces (fixes #3586) (#6379) (Jackson Ray Hamilton)
  • 397e51b Update: Implement outerIIFEBody for indent rule (fixes #6259) (#6382) (David Shepherd)
  • 666da7c Docs: 3.0.0 migration guide (#6521) (Nicholas C. Zakas)
  • b9bf8fb Docs: Update Governance Policy (fixes #6452) (#6522) (Nicholas C. Zakas)
  • 1290657 Update: no-unused-vars ignores read it modifies itself (fixes #6348) (#6535) (Toru Nagashima)
  • d601f6b Fix: Delete cache only when executing on files (fixes #6459) (#6540) (Kai Cataldo)
  • e0d4b19 Breaking: Error thrown/printed if no config found (fixes #5987) (#6538) (Kevin Partington)
  • 18663d4 Fix: false negative of no-useless-rename (fixes #6502) (#6506) (Toru Nagashima)
  • 0a7936d Update: Add fixer for prefer-const (fixes #6448) (#6486) (Nick Heiner)
  • c60341f Chore: Update index and meta for "eslint:recommended" (refs #6403) (#6539) (Mark Pedrotti)
  • 73da28d Better wording for the error reported by the rule "no-else-return" #6411 (#6413) (Olivier Thomann)
  • e06a5b5 Update: Add fixer for arrow-parens (fixes #4766) (#6501) (madmed88)
  • 5f8f3e8 Docs: Remove Box as a sponsor (#6529) (Nicholas C. Zakas)
  • 7dfe0ad Docs: fix max-lines samples (fixes #6516) (#6515) (Dmitriy Shekhovtsov)
  • fa05119 Breaking: Update eslint:recommended (fixes #6403) (#6509) (Nicholas C. Zakas)
  • e96177b Docs: Add "Proposing a Rule Change" link to CONTRIBUTING.md (#6511) (Kevin Partington)
  • bea9096 Docs: Update pull request steps (fixes #6474) (#6510) (Nicholas C. Zakas)
  • 7bcf6e0 Docs: Consistent example headings & text pt3 (refs #5446) (#6492) (Guy Fraser)
  • 1a328d9 Docs: Consistent example headings & text pt4 (refs #5446) (#6493) (Guy Fraser)
  • ff5765e Docs: Consistent example headings & text pt2 (refs #5446)(#6491) (Guy Fraser)
  • 01384fa Docs: Fixing typos (refs #5446)(#6494) (Guy Fraser)
  • 4343ae8 Fix: false negative of object-shorthand (fixes #6429) (#6434) (Toru Nagashima)
  • b7d8c7d Docs: more accurate yoda-speak (#6497) (Tony Lukasavage)
  • 3b0ab0d Fix: add warnIgnored flag to CLIEngine.executeOnText (fixes #6302) (#6305) (Robert Levy)
  • c2c6cec Docs: Mark object-shorthand as fixable. (#6485) (Nick Heiner)
  • 5668236 Fix: Allow objectsInObjects exception when destructuring (fixes #6469) (#6470) (Adam Renklint)
  • 17ac0ae Fix: strict rule reports a syntax error for ES2016 (fixes #6405) (#6464) (Toru Nagashima)
  • 4545123 Docs: Rephrase documentation for no-duplicate-imports (#6463) (Simen Bekkhus)
  • 1b133e3 Docs: improve no-native-reassign and specifying globals (fixes #5358) (#6462) (Toru Nagashima)
  • b179373 Chore: Remove dead code in excuteOnFiles (fixes #6467) (#6466) (Andrew Hutchings)
  • 18fbc4b Chore: Simplify eslint process exit code (fixes #6368) (#6371) (alberto)
  • 58542e4 Breaking: Drop support for node < 4 (fixes #4483) (#6401) (alberto)
  • f50657e Breaking: use default for complexity in eslint:recommended (fixes #6021) (#6410) (alberto)
  • 3e690fb Fix: Exit init early if guide is chosen w/ no package.json (fixes #6476) (#6478) (Kai Cataldo)

The new version differs by 41 commits .

  • 5ec54be 3.0.0
  • 6f49c1e Build: package.json and changelog update for 3.0.0
  • 66de9d8 Docs: Update installation instructions on README (#6569)
  • dc5b78b Breaking: Add require-yield rule to eslint:recommended (fixes #6550) (#6554)
  • 7988427 Fix: lib/config.js tests pass if personal config exists (fixes #6559) (#6566)
  • 4c05967 Docs: Update rule docs for new format (fixes #5417) (#6551)
  • 70da5a8 Docs: Correct link to rules page (#fixes 6553) (#6561)
  • e2b2030 Update: Check RegExp strings for no-regex-spaces (fixes #3586) (#6379)
  • 397e51b Update: Implement outerIIFEBody for indent rule (fixes #6259) (#6382)
  • 666da7c Docs: 3.0.0 migration guide (#6521)
  • b9bf8fb Docs: Update Governance Policy (fixes #6452) (#6522)
  • 1290657 Update: no-unused-vars ignores read it modifies itself (fixes #6348) (#6535)
  • d601f6b Fix: Delete cache only when executing on files (fixes #6459) (#6540)
  • e0d4b19 Breaking: Error thrown/printed if no config found (fixes #5987) (#6538)
  • 18663d4 Fix: false negative of no-useless-rename (fixes #6502) (#6506)

There are 41 commits in total. See the full diff.


This pull request was created by greenkeeper.io.

Tired of seeing this sponsor message? ⚡ greenkeeper upgrade

@codecov-io
Copy link

Current coverage is 100%

Merging #119 into master will not change coverage

@@           master   #119   diff @@
====================================
  Files           9      9          
  Lines         206    206          
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
  Hits          206    206          
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last updated by 6358267...47cf6a8

@sarbbottam sarbbottam merged commit 95bf4d3 into master Jul 2, 2016
@sarbbottam sarbbottam deleted the greenkeeper-eslint-3.0.0 branch July 2, 2016 05:16
@ljharb
Copy link
Collaborator

ljharb commented Jul 2, 2016

@sarbbottam when can this be released?

@ta2edchimp
Copy link
Collaborator

ta2edchimp commented Jul 2, 2016

@sarbbottam we should change package.json's peerDependecies to be "eslint": ">=2.0.0" ...

@ta2edchimp
Copy link
Collaborator

ta2edchimp commented Jul 2, 2016

@ljharb can you make a PR with my proposed change? I could merge it when all tests pass, but not make a PR myself right now ...

@ljharb
Copy link
Collaborator

ljharb commented Jul 2, 2016

@ta2edchimp @sarbbottam i would highly discourage making a peer dep range blindly include new major versions. The proper thing to do is to manually update it every time a new major version is updated.

@ta2edchimp
Copy link
Collaborator

I guess you're right.

@sarbbottam Nevertheless, we should look if we could somehow automate this (update peerDependency of eslint to the version suggested by greenkeeper PRs for the devDependency, as well as making a commit with an appropriate message, to trigger an automated "semantic release").

@ta2edchimp
Copy link
Collaborator

Well, or just do it manually for major releases of eslint, nvm ...

@sarbbottam
Copy link
Owner

sarbbottam commented Jul 2, 2016

Sorry for the late response, traveling with family, long weekend ...

Does #121 addresse the need?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants