feat(rule-finder): add --ext option #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
May 20, 2020
|
@ljharb I aligned this PR with what eslint does : https://github.com/eslint/eslint/blob/3a5fbb3d634be688615950c0a5fa8aead6ff08b5/lib/cli-engine/file-enumerator.js#L150 Note that I had to drop unicode flag in regexp compared to eslint because of node 4 support in tests (I think you should drop support for node 4 and 6, it's pretty old now). |
|
@ljharb Should I change something else? |
ljharb
approved these changes
Jun 1, 2020
Co-authored-by: Jordan Harband <ljharb@gmail.com>
ta2edchimp
approved these changes
Jun 2, 2020
|
@ljharb It would be great to have a new release :) (when you have some time) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #322
depends on #324