breaking: support ESLint 8.x

[MichaelDeBoey]

ESLint v8.0.0 is released 🎉

devDependency compatibility with ESLint 8:

• eslint-plugin-json (Support ESLint 8.x azeemba/eslint-plugin-json#68)
  • feat: support ESLint 8.x azeemba/eslint-plugin-json#70
  • Release

---

Closes #336

[ljharb]

@sarbbottam tests don't seem to be running. is that something you could look into on travis? otherwise i'll have to put up a PR switching us over to github actions.

[ljharb]

Filed #339 which unblocks #338, which unblocks this one.

[ljharb]

Rebased this on top of #338.

[codecov-commenter]

Codecov Report

Merging #337 (e95f4ad) into master (6b4b5a0) will decrease coverage by 1.54%.
The diff coverage is 88.88%.

@@             Coverage Diff             @@
##            master     #337      +/-   ##
===========================================
- Coverage   100.00%   98.45%   -1.55%     
===========================================
  Files            9        9              
  Lines          181      194      +13     
===========================================
+ Hits           181      191      +10     
- Misses           0        3       +3     

Impacted Files	Coverage Δ
src/lib/rule-finder.js	95.89% <87.50%> (-4.11%)	⬇️
src/bin/diff.js	100.00% <100.00%> (ø)
src/bin/find.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b4b5a0...e95f4ad. Read the comment docs.

[ljharb]

@MichaelDeBoey looks like there's a legit test failure - Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './lib/shared/relative-module-resolver' is not defined by "exports" in /home/runner/work/eslint-find-rules/eslint-find-rules/node_modules/@eslint/eslintrc/package.json in test/lib/rule-finder.js:8:20. Presumably require('@eslint/eslintrc/lib/shared/relative-module-resolver') no longer works in v1 of that package, and we need a different try/catch/require in the test file.

[MichaelDeBoey]

@ljharb Fixed the import, together with the fix of the CLIEngine & linter deprecation.

Still some failing tests, but can't figure out how to fix them.
Do you have any pointers into the right direction?

[ljharb]

hmm, now there seems to be even more failing tests than before, just not because of the require issue :-/

[ljharb]

I think since you changed the eslintrc import to not be a deep import, the proxyquire mocks are no longer working.

If there's no deep import way to get to it, then we'll have to mock out the entire eslintrc module.

[himynameisdave]

Dying for this to drop! Just tried building + running this branch against my config, but it wasn't working (eslint.CLIEngine is not a constructor). Happy to test this more though if it helps get this over the finish line!

[MichaelDeBoey]

@ljharb I've mocked @eslint/eslintrc, but tests still seem to fail.
Any idea how I can fix them?

[ljharb]

No, I’ve been playing with it locally too with no success. I have some changes to push up but something is failing to mock getRules properly.

[PaperStrike]

Oh.. I see.

My createRequire mock isn't actually work with the calls to the require created by it. What I have done was just a working resolve method mock. So.. although it simplified the logic on eslint 3 - 7 (@eslint/eslintrc < 1), it doesn't work with @eslint/eslintrc >= 1, too. 😬 (@eslint/eslintrc >= 1 make calls to require created by createRequire.)

Will be much better if we can access the proxyquire-mocked require, or proxyquire itself supports createRequire.

filled thlorenz/proxyquire#265. And looking for alternatives.

[PaperStrike]

Mock problems now should have been fixed in MichaelDeBoey#12 with a workaround.

[ljharb]

hm, so for the promise stuff, i'm not seeing those unhandled rejection warnings locally (altho i can easily reproduce the failures)

[PaperStrike]

@ljharb the unhandled rejection errors should have been fixed in MichaelDeBoey@d66b44c with a workaround. You won't see them if you are using node.js > 14, too. (Don't know why. Just took a look at the checks. Whatever, it's solved.)

eslint-find-rules/src/lib/rule-finder.js

Line 37 in 9af66d5

.map(filePath => cliEngine.isPathIgnored(filePath) ? false : cliEngine.getConfigForFile(filePath))

The promises make this line never always hit the false. Thus the failures.

[ljharb]

Tests are passing, which is great. I'm going to hold off merging this until I add a few other changes, including MichaelDeBoey#14.

[ljharb]

Unfortunately this is a breaking change, so I'm bundling in dropping eslint < 7.