-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): align cliui
version to the version yargs
uses internally
#350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/sarbbottam/eslint-find-rules/blob/master/.github/workflows/node.yml#L16 would need updating as well.
cliui
version to the version yargs
uses internally
after reading CVE-2021-3807 more carefully I see the current so this PR isn't reaaally needed for my original intention. BUT, I think this PR is still valid, so its dependencies are aligned, otherwise users of this package are installing two versions of
|
Sounds good - I’ll merge this tonight, thanks. |
this version is the same that yargs@16.2.0 uses internally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bundled in a few other commits i had sitting unmerged also
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #350 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 185 185
=========================================
Hits 185 185 ☔ View full report in Codecov by Sentry. |
yargs@16.2.0
,yargs@16.2.0
usescliui@7.0.2
cliui
versions so only one gets installed as transient dependencyso there should be no impact to consumers