-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add latest tag #100
Merged
Merged
feat: add latest tag #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanilaKazakevich
requested review from
dmitry-mightydevops,
kseniyashaydurova,
MikhailKorol-saritasa,
populov,
roman-mightydevops,
SergeyDeminSaritasa,
udaltsovra,
luciano-buono,
rtest12,
KrawczowaKris and
darliiin
as code owners
November 21, 2023 13:20
luciano-buono
previously approved these changes
Nov 21, 2023
kseniyashaydurova
requested changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanilaKazakevich pls make minor improvements)
populov
previously approved these changes
Nov 23, 2023
DanilaKazakevich
dismissed stale reviews from populov and luciano-buono
via
November 24, 2023 10:17
a39aed2
kseniyashaydurova
previously approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanilaKazakevich pls generate docs in the correct way.
SergeyDeminSaritasa
previously approved these changes
Nov 27, 2023
udaltsovra
previously approved these changes
Nov 28, 2023
populov
previously approved these changes
Nov 28, 2023
luciano-buono
previously approved these changes
Dec 6, 2023
udaltsovra
previously approved these changes
Dec 7, 2023
MikhailKorol-saritasa
previously approved these changes
Dec 7, 2023
roman-mightydevops
previously approved these changes
Dec 7, 2023
populov
previously approved these changes
Dec 7, 2023
dmitry-mightydevops
approved these changes
Dec 8, 2023
kseniyashaydurova
previously approved these changes
Dec 8, 2023
dmitry-mightydevops
previously approved these changes
Dec 9, 2023
SergeyDeminSaritasa
previously approved these changes
Dec 13, 2023
DanilaKazakevich
dismissed stale reviews from SergeyDeminSaritasa, dmitry-mightydevops, kseniyashaydurova, populov, roman-mightydevops, MikhailKorol-saritasa, udaltsovra, and luciano-buono
via
December 28, 2023 06:13
5465140
roman-mightydevops
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Task: https://saritasa.atlassian.net/browse/SD-373
Why?
It is needed for xrayimg project. We have develepment env on the project placed on PC in
Krasnoyarsk office -> Hyper-V server -> Virtual machine -> docker compose
. Also all future production servers will be created with in same way (VM and docker compose is 100%).We deploy the new version of backend on the servers with watchtower. It checks AWS ECR for the new uploaded image and update running containers. The easiest way to do it is
:latest
tag. It is here: https://github.com/saritasa-nest/xrayimg-infra-aws/blob/feature/local-server/private/docker-compose.yaml#L12How?
We can add both tags
${env}-${commit_hash}
(i.e.:dev-dsjfh43
) and:latest
on the built image in tekton-pipelines.It isn't default behaviour now. You must enable this by adding below code in triggerBinding:
Exmaples:
Output from buildpacks step:
Saving 190499200307.dkr.ecr.us-west-2.amazonaws.com/ygm/staging/backend:staging-802d5f2... *** Images (sha256:9e15b5041fec79448e25948503ddd68ee8563d7d3bacacb4f3f20c1e5a23b891): 190499200307.dkr.ecr.us-west-2.amazonaws.com/ygm/staging/backend:staging-802d5f2 190499200307.dkr.ecr.us-west-2.amazonaws.com/ygm/staging/backend:latest
Some images:
How parameter looks:
How images look in ECR: