-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add 'get' verb 'pod/exec' permissions in readonly roles #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
populov
requested review from
dmitry-mightydevops,
DanilaKazakevich,
kseniyashaydurova,
MikhailKorol-saritasa,
roman-mightydevops,
SergeyDeminSaritasa,
udaltsovra,
luciano-buono,
rtest12,
KrawczowaKris and
darliiin
as code owners
July 23, 2024 10:44
populov
changed the title
Add 'get' verb 'pod/exec' permissions in readonly roles
fix: add 'get' verb 'pod/exec' permissions in readonly roles
Jul 23, 2024
SergeyDeminSaritasa
previously approved these changes
Jul 24, 2024
udaltsovra
reviewed
Jul 24, 2024
luciano-buono
previously approved these changes
Jul 24, 2024
kseniyashaydurova
previously approved these changes
Jul 25, 2024
Co-authored-by: Kseniya Shaydurova <kseniya.shaydurova@saritasa.com>
populov
dismissed stale reviews from kseniyashaydurova, luciano-buono, and SergeyDeminSaritasa
via
July 25, 2024 07:06
45f747d
rtest12
approved these changes
Jul 25, 2024
darliiin
approved these changes
Jul 25, 2024
udaltsovra
approved these changes
Jul 26, 2024
DanilaKazakevich
approved these changes
Jul 26, 2024
SergeyDeminSaritasa
approved these changes
Jul 26, 2024
KrawczowaKris
approved these changes
Jul 29, 2024
dmitry-mightydevops
approved these changes
Jul 29, 2024
MikhailKorol-saritasa
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Task: SD-373
Basically, repeats this PR solution in
rbac
helmchart.kubectl exec ...
requires GET /pods/exec permissions since 1.30 (not onlycreate
).Fix Kubernetes RBAC resources to allow developers execute commands in project pods.