Refactor libs, add tests, preserve comments in sorted list #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the comment munging is currently broken on sort key syntax * the pre/post-processing of jinja triple-curly braces does work Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>
Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>
* sorting is still an issue and apparently very !wip Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>
Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>
* sprinkle some pylint: disable for issues that are not issues Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>
sorted() returs a normal list which loses info in extra members of the CommentedSeq object, but the sort method sorts elements inside the existing CommentedSeq object
Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>
Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>
Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>
sarnold
changed the title
Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.