Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oscal data analysis #13

Merged
merged 10 commits into from
Mar 24, 2024
Merged

Oscal data analysis #13

merged 10 commits into from
Mar 24, 2024

Conversation

sarnold
Copy link
Owner

@sarnold sarnold commented Mar 18, 2024

  • add new module and support code

Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
* add .repolite.yml for syncing oscal-content repo
* update tests and vendor tox plugin for shared envs

Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
@pep8speaks
Copy link

pep8speaks commented Mar 18, 2024

Hello @sarnold! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 67:91: E501 line too long (91 > 90 characters)
Line 30:91: E501 line too long (99 > 90 characters)

Comment last updated at 2024-03-23 23:01:17 UTC

Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
* limit fuzzy match results using startswith input ID string
* cleanup package modules and tests, move initial profile funcs

Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
* for each type, parse into a list of objects and return the list
* where simple text files are something like the control IDs
  in tests/data

Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
Copy link

Package Line Rate Branch Rate Complexity Health
src.ymltoxml 96% 91% 0
Summary 96% (237 / 247) 91% (78 / 86) 0

Copy link

Hello @sarnold! Thanks for opening this PR. We found the following information based on analysis of the coverage report:

Base Branch Rate coverage is 85%
Merging d62e1c9 into main will increase coverage by 6%

Nice work, @sarnold. Cheers! 🍻

@sarnold sarnold merged commit adc965b into main Mar 24, 2024
34 checks passed
@sarnold sarnold deleted the oscal-data branch March 24, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants