Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Id munging and cleanup #17

Merged
merged 13 commits into from
Jul 6, 2024
Merged

Id munging and cleanup #17

merged 13 commits into from
Jul 6, 2024

Conversation

sarnold
Copy link
Owner

@sarnold sarnold commented May 28, 2024

  • allow xform_id to remove trailing zeros from ID strings => -00
  • cleanup pre-commit config

@sarnold
chg: dev: allow xform_id to strip trailing zeros from ID strings
18a5f46 
Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
@sarnold
chg: dev: make id-strip default off, update pre-commit cfg, add cleanup
91caae0 
Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
@sarnold sarnold force-pushed the id-munging branch 2 times, most recently from fdc9003 to 9460094 Compare May 29, 2024 05:01
@sarnold
chg: dev: remove py38 from test matrix
4469cdb 
* xform_id(id, strip) needs at least py39 if strip is True, so
  fallback to nothing if no member attribute
* skip strip test on < py39

Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
@sarnold
chg: add quiet cmdline arg, update attr arg so arg takes precedence
7fcc6d3 
* make sure arg overrides file value, no value means no report

Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
@sarnold
fix: cleanup test data for new args and output
aef2d90 
Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
@sarnold
chg: switch oscal text report output to semicolon instead of comma
73c4278 
Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
@sarnold
chg: usr: improve xform_id, update tests, cleanup some lint
615f469 
Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
@sarnold
chg: strip down xform_id and update tests !refactor
3da7d2f 
* limit handling of trailing/leading zeros to forward direction only

Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
@sarnold
chg: usr: refactor for testing, cleanup script imports and test data
fa17ceb 
* add some new control data files for test support

Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
@sarnold
chg: cleanup unnecessary branches, update expected test output
3c8508b 
Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
@sarnold
chg: dev: allow for adjustable CSV delimiter in oscal.yaml
fac4886 
Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
@sarnold
chg: dev: cleanup readme and docstrings
4d22b31 
Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
@sarnold
new: dev: add new_csv_file option, update tests and readme
5905052 
Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2024

Package Line Rate Branch Rate Complexity Health
src.yaml_tools 96% 95% 0 ✔
Summary 96% (400 / 415) 95% (164 / 172) 0 ✔

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2024

Hello @sarnold! Thanks for opening this PR. We found the following information based on analysis of the coverage report:

Base Branch Rate coverage is 95%
Merging 5f0c735 into main will not change coverage

Nice work, @sarnold. Cheers! 🍻

@sarnold sarnold merged commit b3c7976 into main Jul 6, 2024
34 checks passed
@sarnold sarnold deleted the id-munging branch August 27, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sarnold