Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle anaconda python (installed via pyenv) #20

Closed
AlJohri opened this issue Oct 16, 2018 · 7 comments
Closed

handle anaconda python (installed via pyenv) #20

AlJohri opened this issue Oct 16, 2018 · 7 comments

Comments

@AlJohri
Copy link
Contributor

AlJohri commented Oct 16, 2018

Fails to parse anaconda python installed via pyenv:

ValueError: Not a valid python version: <LegacyVersion('anaconda3-5.0.1')>
pipenv.vendor.pythonfinder.exceptions.InvalidPythonVersion: /Users/johria/.pyenv/versions/anaconda3-5.0.1/bin/anaconda is not a valid python path

See pypa/pipenv#3044 for full traceback

@AlJohri
Copy link
Contributor Author

AlJohri commented Oct 16, 2018

looked into how this is implemented. this may be hard- can we at least default ignore_unsupported=True? without this pipenv entirely stops working if you have a invalid python installed

@AlJohri
Copy link
Contributor Author

AlJohri commented Oct 16, 2018

downgraded to pipenv 2018.7.1 for now

@AlJohri
Copy link
Contributor Author

AlJohri commented Oct 16, 2018

downgrading didn't work, ran into:

Installing requests...
Traceback (most recent call last):
  File "/Users/johria/.pyenv/versions/3.6.5/bin/pipenv", line 11, in <module>
    sys.exit(cli())
  File "/Users/johria/.pyenv/versions/3.6.5/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/Users/johria/.pyenv/versions/3.6.5/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/Users/johria/.pyenv/versions/3.6.5/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/johria/.pyenv/versions/3.6.5/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/johria/.pyenv/versions/3.6.5/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/Users/johria/.pyenv/versions/3.6.5/lib/python3.6/site-packages/pipenv/cli.py", line 435, in install
    selective_upgrade=selective_upgrade,
  File "/Users/johria/.pyenv/versions/3.6.5/lib/python3.6/site-packages/pipenv/core.py", line 1971, in do_install
    pypi_mirror=pypi_mirror,
  File "/Users/johria/.pyenv/versions/3.6.5/lib/python3.6/site-packages/pipenv/core.py", line 1375, in pip_install
    package_name.split('--hash')[0].split('--trusted-host')[0]
  File "/Users/johria/.pyenv/versions/3.6.5/lib/python3.6/site-packages/pipenv/vendor/requirementslib/models/requirements.py", line 704, in from_line
    line, extras = _strip_extras(line)
TypeError: 'module' object is not callable

going to get rid of anaconda 😭

@techalchemy
Copy link
Member

Hmmm I thought we did set that. That is a gross oversight and someone at continuum is going to be mad at me :(

You can use the full path I think

techalchemy added a commit that referenced this issue Oct 18, 2018
- Improve lookups and fallbacks for all finders
- Add support for named pythons, such as `anaconda...`
- Fix `pythonz` failures
- Fixes #19
- Fixes #20

Signed-off-by: Dan Ryan <dan@danryan.co>
@AlJohri
Copy link
Contributor Author

AlJohri commented Oct 18, 2018

thanks for the quick fix @techalchemy! FWIW, full path did work earlier

@302sk
Copy link

302sk commented Oct 23, 2018

Hmmm I thought we did set that. That is a gross oversight and someone at continuum is going to be mad at me :(

You can use the full path I think

What does full path mean?

@AlJohri
Copy link
Contributor Author

AlJohri commented Oct 23, 2018

@302sk pipenv install --python=/Users/johria/.pyenv/versions/3.6.5/bin/python or even pipenv install --python=python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants