Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py using unicode without declaring coding #62

Closed
jayvdb opened this issue Mar 7, 2019 · 2 comments
Closed

setup.py using unicode without declaring coding #62

jayvdb opened this issue Mar 7, 2019 · 2 comments

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Mar 7, 2019 •
edited

Hi, I am currently packaging all dependencies of pipenv, and encountered a few packages by @sarugaku and @kennethreitz where the setup.py uses the unicode …, in messages to be emitted to the user, but the setup.py doesnt including a coding declaration of utf8. As a result, python spits the dummy and wont run setup.py.

It looks like templated code, possibly invoke which seems regularly used in this family of packages, so the core problem might be upstream.
@jayvdb
Copy link
Contributor Author

jayvdb commented Mar 8, 2019

Another one at https://github.com/pypa/pipenv/blob/master/tests/pytest-pypi/setup.py

@techalchemy
Copy link
Member

seems likely that it is part of one of kenneth's templates indeed

techalchemy added a commit that referenced this issue Mar 8, 2019
@techalchemy
Fix non-unicode formatted string with special char
50d938c 
- Fixes #62

Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy techalchemy mentioned this issue Mar 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayvdb @techalchemy