Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pyenv usage for windows and linux. #137

Merged
merged 4 commits into from
May 16, 2023
Merged

Fix pyenv usage for windows and linux. #137

merged 4 commits into from
May 16, 2023

Conversation

matteius
Copy link
Contributor

  • pyenv shims were not getting removed from the PATH
  • versions that weren't already on the PATH were not being found.
  • detecting if pyenv is installed was based on an env var but other parts of the code determine it based on if pyenv is available on the path -- normalize this behavior towards the later.

@matteius matteius requested a review from oz123 May 14, 2023 17:09
@oz123 oz123 merged commit 2293771 into master May 16, 2023
@oz123 oz123 deleted the fix-pyenv branch May 16, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oz123 oz123 oz123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteius @oz123