Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code and settings #147

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Remove dead code and settings #147

merged 2 commits into from
Oct 22, 2023

Conversation

Secrus
Copy link
Contributor

@Secrus Secrus commented Jul 25, 2023

Browsing through the code, I have noticed some "dead" fragments.

tests/test_environment.py Show resolved Hide resolved
@matteius
Copy link
Contributor

Can this be updated with the conflicts resolved?

@Secrus
Copy link
Contributor Author

Secrus commented Oct 19, 2023

Can this be updated with the conflicts resolved?

Hey, yes, sorry. Got busy with stuff IRL. I will try to fix the issues with this PR over the coming weekend.

@Secrus
Copy link
Contributor Author

Secrus commented Oct 22, 2023

Can this be updated with the conflicts resolved?

@matteius I have split this into 2 commits (one for applying black and ruff standards where it was missed for some reason and 2nd for an actual dead code drop). It should be good to merge now

@Secrus Secrus requested a review from oz123 October 22, 2023 21:21
@oz123 oz123 merged commit c62179d into sarugaku:master Oct 22, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants