Fix finding pyenv python versions issue when pyenv version file not present #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really need to write some tests. If you have any interest (you are making a lot of PRs here) I don't mind adding you as a maintainer -- you are catching a lot of my bugs :p |
|
Yeah, definitely it will be nice to have tests. Thanks! As far as I can see I'm going to use pipenv in my own/company projects for a long time, so I would love to contribute to these projects which pipenv depends. So far I think what I mainly can do is bug fixing, helping these projects' features not drifting in the development. I'd also love to add new features, but that depends the spare time I have such as in weekends. But I definitely will try to do that. If you're fine with it, I'm glad to be one of the maintainers. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33