Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project since mypy is introduced #52

Merged
merged 10 commits into from
Dec 4, 2018

Conversation

jxltom
Copy link
Collaborator

@jxltom jxltom commented Dec 2, 2018

Since mypy in introduced in #51, this PR update requirements, add mypy to pipenv's scripts and update relevant .gitignore

It is blocked by #53 and #51 for now

@jxltom jxltom added the blocked label Dec 2, 2018
@jxltom
Copy link
Collaborator Author

jxltom commented Dec 2, 2018

I'm curious why typed-ast, which is a dep of mypy and requires python3.3 or higher, needs markers manually? Why pipenv can not add markers automatically... 😕

@jxltom jxltom force-pushed the adding-mypy-to-project branch 2 times, most recently from d3db2bc to 3a8de9c Compare December 2, 2018 15:44
@techalchemy
Copy link
Member

Mypy itself doesn’t require markers does it? You just need typing; python_version<3.5

@jxltom
Copy link
Collaborator Author

jxltom commented Dec 3, 2018

Actually mypy required python 3.4+, otherwise pipenv will fail on locking

Check here https://github.com/python/mypy/blob/master/setup.py#L8-L10

@techalchemy
Copy link
Member

Ah yeah. Anyway we considered cascading markers down. Now that we have a way to check reverse dependencies we can do that

@jxltom
Copy link
Collaborator Author

jxltom commented Dec 3, 2018

That will be great

Pipfile.lock Outdated
@@ -72,30 +64,6 @@
],
"version": "==2.6.0"
},
"backports.functools-lru-cache": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now do you see why i want --keep-outdated to respect things that used to be in the pipfile even if we can't find a parent for them anymore? This is a valid dependency!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. But I'm curious why it is removed. I'm using python3 within the virtualenv and locking. Maybe you are using python2?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generate and update with both versions typically to make sure I don’t have failing builds, which is why I focused on the use case of not removing dependencies that the resolver thinks are invalid

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, feels the same now

Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy techalchemy merged commit 1741a4f into sarugaku:master Dec 4, 2018
@jxltom jxltom deleted the adding-mypy-to-project branch December 4, 2018 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants