-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project since mypy is introduced #52
Conversation
I'm curious why |
d3db2bc
to
3a8de9c
Compare
Mypy itself doesn’t require markers does it? You just need |
Actually mypy required python 3.4+, otherwise pipenv will fail on locking Check here https://github.com/python/mypy/blob/master/setup.py#L8-L10 |
Ah yeah. Anyway we considered cascading markers down. Now that we have a way to check reverse dependencies we can do that |
That will be great |
Pipfile.lock
Outdated
@@ -72,30 +64,6 @@ | |||
], | |||
"version": "==2.6.0" | |||
}, | |||
"backports.functools-lru-cache": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now do you see why i want --keep-outdated
to respect things that used to be in the pipfile even if we can't find a parent for them anymore? This is a valid dependency!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. But I'm curious why it is removed. I'm using python3 within the virtualenv and locking. Maybe you are using python2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generate and update with both versions typically to make sure I don’t have failing builds, which is why I focused on the use case of not removing dependencies that the resolver thinks are invalid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, feels the same now
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Since mypy in introduced in #51, this PR update requirements, add
mypy
to pipenv's scripts and update relevant.gitignore
It is blocked by #53 and #51 for now