-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unsupported proc format #78
Comments
Pull requests would be welcomed. |
We're observing that same issue on Intel Mac devices. It bubbles up through Poetry, breaking some of its functions. @uranusjr I could look into a PR, but I'm not sure what the fix would be as neither of this file apparently exist on Macs? |
I confirm this bug too. The bug is in the proc.py:30
Since MacOS systems do not contain a "/proc" file system, the script is always raising the error. |
fixed this - #79 |
1.5.3 has been released. |
Thanks for the very speedy fix folks! ❤️ |
Bumps [shellingham](https://github.com/sarugaku/shellingham) from 1.5.1 to 1.5.3. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/sarugaku/shellingham/blob/master/CHANGELOG.rst">shellingham's changelog</a>.</em></p> <blockquote> <h1>1.5.3 (2023-08-17)</h1> <h2>Bug Fixes</h2> <ul> <li>Detect proc format eagerly so it throws the error at the correct location. <code>[#78](sarugaku/shellingham#78) <https://github.com/sarugaku/shellingham/issues/78></code>_</li> </ul> <h1>1.5.2 (2023-08-16)</h1> <h2>Bug Fixes</h2> <ul> <li>Fixed a regression causing <code>ShellDetectionFailure</code> if <code>/proc</code> is used for process lookup. <code>[#72](sarugaku/shellingham#72) <https://github.com/sarugaku/shellingham/issues/72></code>_</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/sarugaku/shellingham/commit/b8ba512b6f53807416fa446ccec295c79131cc76"><code>b8ba512</code></a> Bump to 1.5.3</li> <li><a href="https://github.com/sarugaku/shellingham/commit/ed3066f6eafd9e7e7c6ac53e35626532af2cbd2c"><code>ed3066f</code></a> Merge pull request <a href="https://github.com/sarugaku/shellingham/issues/79">#79</a> from sneakers-the-rat/bugfix-detect-proc</li> <li><a href="https://github.com/sarugaku/shellingham/commit/4619ac9ae6f5b8edd37b02e671efcf1230bb3fb7"><code>4619ac9</code></a> Raise exception eagerly in generator</li> <li><a href="https://github.com/sarugaku/shellingham/commit/9ef1e3126d7a1fa43518477968c763e641b26c6a"><code>9ef1e31</code></a> Enable ruff and black on CI</li> <li><a href="https://github.com/sarugaku/shellingham/commit/bf9f580f7b3f0ff2254730462ed7b50898dd1aa8"><code>bf9f580</code></a> Bump to 1.5.2</li> <li><a href="https://github.com/sarugaku/shellingham/commit/c2b94318e30d140b2912a9e03959fc8189781c61"><code>c2b9431</code></a> Merge pull request <a href="https://github.com/sarugaku/shellingham/issues/75">#75</a> from Moomboh/master</li> <li><a href="https://github.com/sarugaku/shellingham/commit/82b66850019e78840b56ca18fb008b79acf70743"><code>82b6685</code></a> Use iterator to inspect parents</li> <li><a href="https://github.com/sarugaku/shellingham/commit/6b3410912f8bdc6ee10aee2cb8c50fb2568e6820"><code>6b34109</code></a> revert ps call to version before #7bf9e76</li> <li><a href="https://github.com/sarugaku/shellingham/commit/71a3b726ec7ed0655b62df124a70557d312d52ab"><code>71a3b72</code></a> improve qemu regex readability</li> <li><a href="https://github.com/sarugaku/shellingham/commit/7bf9e76accdf6e9e92f8e27f9c9341e47ea8489d"><code>7bf9e76</code></a> refactor proc tree iter and ps parsing</li> <li>Additional commits viewable in <a href="https://github.com/sarugaku/shellingham/compare/1.5.1...1.5.3">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=shellingham&package-manager=pip&previous-version=1.5.1&new-version=1.5.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Running an Apple M1 Pro, I started to get
as part of running
poetry shell
Upon digging, I found this library and saw fairly recent updates. After downgrading from 1.5.2 to 1.5.0, issues is gone.
Have you maybe introduced a regression for M1s?
The text was updated successfully, but these errors were encountered: