Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and cleanups for Course and cumulative GPA #162

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

gary-kim
Copy link
Member

@gary-kim gary-kim commented Apr 5, 2020

TODO:

  • Fully fix calculation
    • Fix counting courses without a normal grade
    • Still seems to be a bit off from what it should be. Gonna investigate further.
  • Nitpicks
  • Migrate to Vue
    • Go to Cialfo for official GPA message

@gary-kim gary-kim added the bug Something isn't working label Apr 5, 2020
@gary-kim gary-kim added this to the Open Beta v0.21.0 milestone Apr 5, 2020
@Suhas-13
Copy link
Member

Do you think it would be possible to release the current cumulative-gpa feature with just the fix you made in this PR?

@gary-kim
Copy link
Member Author

Whoops, this escaped my mind. Feel free to ping me if it looks like I forgot about something. Let me just get at least the Vue migration done.

@gary-kim gary-kim force-pushed the fixes/160/cleanups-and-fixes branch 2 times, most recently from 164c9d3 to 07da93f Compare April 16, 2020 15:43
@gary-kim gary-kim requested a review from Suhas-13 April 16, 2020 15:44
@gary-kim gary-kim force-pushed the fixes/160/cleanups-and-fixes branch from 07da93f to 156e042 Compare April 17, 2020 01:22
@Suhas-13
Copy link
Member

Seems to be good, just a question though, does Cialfo include the current semester when calculating? If it doesn't then the extension might be off from Cialfo which might confuse some users.

@Suhas-13
Copy link
Member

I don't think Cialfo includes semesters in progress GPA but I may be wrong, if it does not it might be good to add something to the disclaimer indicating that Cialfo does not include that whereas the extension does and as such may be different.

@gary-kim
Copy link
Member Author

Good point. How about we phrase it like "You can check your official GPA at Cialfo (does not include current semester)"?

@Suhas-13
Copy link
Member

That sounds good, should be clear enough.

Signed-off-by: Gary Kim <gary@garykim.dev>
@gary-kim gary-kim force-pushed the fixes/160/cleanups-and-fixes branch from 156e042 to 634c1c5 Compare April 17, 2020 13:21
@gary-kim gary-kim requested a review from Suhas-13 April 17, 2020 13:22
@gary-kim gary-kim merged commit 1a65fa6 into master Apr 17, 2020
@gary-kim gary-kim deleted the fixes/160/cleanups-and-fixes branch April 17, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants