-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and cleanups for Course and cumulative GPA #162
Conversation
Do you think it would be possible to release the current cumulative-gpa feature with just the fix you made in this PR? |
Whoops, this escaped my mind. Feel free to ping me if it looks like I forgot about something. Let me just get at least the Vue migration done. |
164c9d3
to
07da93f
Compare
07da93f
to
156e042
Compare
Seems to be good, just a question though, does Cialfo include the current semester when calculating? If it doesn't then the extension might be off from Cialfo which might confuse some users. |
I don't think Cialfo includes semesters in progress GPA but I may be wrong, if it does not it might be good to add something to the disclaimer indicating that Cialfo does not include that whereas the extension does and as such may be different. |
Good point. How about we phrase it like "You can check your official GPA at Cialfo (does not include current semester)"? |
That sounds good, should be clear enough. |
Signed-off-by: Gary Kim <gary@garykim.dev>
156e042
to
634c1c5
Compare
TODO: