Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix options page and remove extension info option #252

Merged
merged 4 commits into from
Jan 2, 2021
Merged

Fix options page and remove extension info option #252

merged 4 commits into from
Jan 2, 2021

Conversation

Suhas-13
Copy link
Member

@Suhas-13 Suhas-13 commented Jan 2, 2021 •
edited
Loading

Fix options page and remove extension info option

closes #239

Suhas Hariharan added 4 commits January 2, 2021 14:03
added default config method
d5ebec5 
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
fixed optins page
d1ea073 
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
made last seen grades opt in
d6f0b46 
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
removed extension info option
3576022 
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
@Suhas-13 Suhas-13 requested a review from priime0 January 2, 2021 06:07
@Suhas-13 Suhas-13 added the enhancement Improvement to a feature label Jan 2, 2021
priime0
priime0 approved these changes Jan 2, 2021
View reviewed changes
Copy link
Contributor

@priime0 priime0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@Suhas-13 Suhas-13 merged commit 20bcddf into master Jan 2, 2021
@Suhas-13 Suhas-13 added this to the Open Beta v0.22.3 milestone Jan 2, 2021
@gary-kim
Copy link
Member

gary-kim commented Jan 3, 2021

Oh, what was the removal of the extension info option for?

@Suhas-13
Copy link
Member Author

Suhas-13 commented Jan 3, 2021

I just realised it wasn't an option in the extension option page so I thought I'd just remove it for now, if you'd prefer I can add it back and make it a proper selectable option in the page.

@gary-kim
Copy link
Member

gary-kim commented Jan 3, 2021

It's used to control whether or not the extension info page is open or closed:

saspes/src/js/components/ExtensionInfo.vue

Lines 87 to 90 in f48f55a

toggleInfo () {
this.showInfo = !this.showInfo;
browser.storage.local.set({ showExtensionInfo: this.showInfo });
},

@Suhas-13
Copy link
Member Author

Suhas-13 commented Jan 4, 2021

ah, sorry I completely missed that functionality, I assumed it was yet to be implemented on the options page. I can re-add that in another PR.

@Suhas-13
Copy link
Member Author

Suhas-13 commented Jan 5, 2021

closes #239

@megagames-me megagames-me deleted the fix-options-page branch January 9, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priime0 priime0 priime0 approved these changes

Assignees
No one assigned
Labels
enhancement Improvement to a feature
Projects
None yet
Milestone
Open Beta v0.22.3
Development

Successfully merging this pull request may close these issues.

Make last-seen-grades opt in instead of opt out
3 participants
@Suhas-13 @gary-kim @priime0