Re-adds percentages and fix powerschool changes #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 5, 2021 18:53
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Suhas-13
force-pushed
the
fix-powerschool-changes
branch
from
eaa5e52
to
327a3f1
Compare
Suhas-13
changed the title
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Suhas-13
force-pushed
the
fix-powerschool-changes
branch
from
0a05ced
to
ec8eac0
Compare
added 9 commits
October 12, 2021 13:05
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
ARtheboss
approved these changes
Oct 13, 2021
|
I think there are some issues with the tests. will likely need to fix them soon. |
Suhas-13
force-pushed
the
fix-powerschool-changes
branch
from
7447d7e
to
2d56488
Compare
|
I've fixed the tests so it should work for future PR's. The powerschool decode comment is slightly different. |
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Suhas-13
force-pushed
the
fix-powerschool-changes
branch
from
2d56488
to
057bd07
Compare
added 4 commits
October 13, 2021 12:19
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the percentages feature by accessing a different endpoint to obtain percentages(has been hidden on scores.html), and other minor issues caused by powerschool changes.