Fixed issues due to PowerSchool UI update and fixed category weighting bug #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 3, 2021 20:46
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Suhas-13
force-pushed
the
fix-ps-ui-update
branch
from
41e7efb
to
0d30ba0
Compare
ARtheboss
reviewed
Nov 3, 2021
ARtheboss
reviewed
Nov 3, 2021
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
ARtheboss
reviewed
Nov 3, 2021
|
@Suhas-13 For category weighting the flags (such as exempted and not included in final grade) are not transferring to the updated grade table. |
|
Also, I think the saved weightings from the previous version may not be getting transfered. However, weightings saved in this version do get saved. I don't think this is a major issue. |
added 2 commits
November 3, 2021 21:27
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
|
That might just be you reinstalling the extension when you add the new version.
…On Wed, Nov 3, 2021, 9:06 PM ARtheboss ***@***.***> wrote:
Also, I think the saved weightings from the previous version may not be
getting transfered. However, weightings saved in this version do get saved.
I don't think this is a major issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#308 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKLSRYRF7MBZQLQD6MGGVETUKEXVFANCNFSM5HI2UFJA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
CONFIDENTIALITY CAUTION: This message is intended only for the use of the
individual or entity to whom it is addressed and contains information that
is privileged and confidential. If you, the reader of this message, are not
the intended recipient, you should not disseminate, distribute or copy this
communication. If you have received this communication in error, please
notify us immediately by return email and delete the original message.
Unless it relates to the official business of Singapore American School,
any opinions or matters expressed in this message are those of the
individual sender.
|
ARtheboss
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed changes resulting from the powerschool UI update. moved to using powerschool API for some functions. should try and move other stuff over in the future as it'll make it easier to handle UI updates.