Fix CSP issue in Chrome v130 #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anvay Mathur <contact@anvaymathur.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, Chrome pushed out v130 which enabled a feature known as
use_dynamic_urlwithinweb_accessible_resourcesin the manifest file. By default, the version of CRX.js I was using setuse_dynamic_urlto true for all the files SASPES needs to work. However, this feature was implemented wrong (see this bug report) and prevents any JavaScript files from being loaded. This prevents the extension itself from loading, which is why many users may have noticed the extension just disappeared. I have updated CRX.js to the latest version, which setsuse_dynamic_urlto false which prevents this bug. Chrome has also fixed this bug and it will be included in later updates soon.AFAIK, this bug has existed since early-October, but because I tend to ignore the big red button warning me to update Chrome, I did not observe it until now. This was reported to me only this morning, so I would like to apologize to everyone who were inconvenienced by this bug.