Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dry-run,no-color,with-breakpoints,continue-on-error functionality #106

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

karampok
Copy link
Contributor

As part of me using the library for demos, I had to modify the library code to add the following functions

--dry-run                     run the demo and only prints the commands (default: true)
--no-color                    run the demo and output to be without colors (default: false)
--with-breakpoints            breakpoint (default: false)
--continue-on-error           continue if there a step fails (default: false)

This is a fully draft PR. In case you want, I can work towards improving the code for merging. Thanks

Copy link
Owner

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you!

@saschagrunert saschagrunert marked this pull request as ready for review May 31, 2023 12:03
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #106 (6777e63) into main (5f31cbd) will decrease coverage by 3.76%.
Report is 1 commits behind head on main.
The diff coverage is 55.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   73.14%   69.38%   -3.76%     
==========================================
  Files           3        3              
  Lines         242      294      +52     
==========================================
+ Hits          177      204      +27     
- Misses         41       60      +19     
- Partials       24       30       +6     

@saschagrunert
Copy link
Owner

@karampok do you mind a rebase?

@karampok
Copy link
Contributor Author

Is there anything more from my side?

Copy link
Owner

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saschagrunert saschagrunert merged commit 53b22d5 into saschagrunert:main Mar 14, 2024
3 of 5 checks passed
@karampok
Copy link
Contributor Author

cool, thanks!

@saschagrunert
Copy link
Owner

We may wanna update the README.md documentation, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants