Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to make github plugin more useful. #28

Merged
merged 3 commits into from
Dec 16, 2013

Conversation

aspiers
Copy link

@aspiers aspiers commented Jun 17, 2013

Rather than merely showing counts ("I did 731 pull requests this week, look how amazing I am!"), show what was actually worked on.

This is probably too verbose, and needs some extra de-duplication intelligence, but I think it's definitely a step in the right direction, and maybe even good enough to merge. Feedback welcome.

TODO list:

  • each comment on an issue or PR results in the same line in the report
  • if you create a PR, it's probably not worth mentioning that you commented on it
  • work on related repos (origin and fork) need to be grouped together
  • all work on a pull request needs to be grouped together
  • rebasing or fast-forwarding a personal fork branch and pushing it generates uninteresting events
  • repeated git push -f cause a lot of duplicate info
  • ensure items within a single list are always chronologically sorted
  • add repo inclusion / exclusion lists

@aspiers
Copy link
Author

aspiers commented Jun 17, 2013

Another issue is that if you rebase a personal branch against updated upstream and then push it, it shows all the new upstream commits which you probably didn't have anything to do with, just because those new upstream commits are now in your fork for the first time.

@aspiers
Copy link
Author

aspiers commented Jun 17, 2013

See this work report for sample output.

@aspiers
Copy link
Author

aspiers commented Jul 29, 2013

Rebased onto latest upstream master. @mvidner just used this, so maybe it's ready to merge now?

@aspiers
Copy link
Author

aspiers commented Sep 2, 2013

Rebased again ...

@saschpe
Copy link
Owner

saschpe commented Sep 6, 2013

I agree in general but still wonder about the verbosity

@aspiers
Copy link
Author

aspiers commented Sep 6, 2013

Sure - see the TODO list above. But it's quite easy to delete generated output in the mean time.

@aspiers
Copy link
Author

aspiers commented Dec 16, 2013

Rebased onto latest master. @saschpe - are you objecting to this revamp? Even if so, the other two commits should be non-contentious.

saschpe added a commit that referenced this pull request Dec 16, 2013
Attempt to make github plugin more useful.
@saschpe saschpe merged commit dc55fa1 into saschpe:master Dec 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants