Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop / pause #21

Closed
Kris-B opened this issue Aug 2, 2018 · 5 comments
Closed

stop / pause #21

Kris-B opened this issue Aug 2, 2018 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
v0.1.2

Comments

@Kris-B
Copy link

Kris-B commented Aug 2, 2018

How to stop or pause a tween?
@sasha240100
Copy link
Owner

@Kris-B Yet this functionality is unimplemented. Would be nice if you could do a PR that will add the following functionality.

const tween = new Between(...).time(2000); // tween starts immediately
tween.stop(); // Stops the tween
tween.play(); // Continues the tween

/ping @alexko30 @IlyaSenko

@sasha240100 sasha240100 added enhancement New feature or request help wanted Extra attention is needed labels Aug 2, 2018
@Kris-B
Copy link
Author

Kris-B commented Aug 2, 2018

@sasha240100 thanks for the feedback, however I have no idea how to implement this...

@hirako2000
Copy link
Contributor

hirako2000 commented Aug 7, 2018 •
edited
Loading

will do.
PR #31

hirako2000 added a commit to hirako2000/between.js that referenced this issue Aug 7, 2018
@hirako2000
Adds type definitions for new functions sasha240100#21
0cdfe02
hirako2000 added a commit to hirako2000/between.js that referenced this issue Aug 7, 2018
@hirako2000
Adjusts heading in README as it breaks the table of content when auto…
827cc0e 
… fixing sasha240100#21
hirako2000 added a commit to hirako2000/between.js that referenced this issue Aug 8, 2018
@hirako2000
Fixes the pause flag logic as it was using the global (shared) state,…
8f40dc1 
… use Symbol for the paused flag , and replace function with proper getter sasha240100#21
hirako2000 added a commit to hirako2000/between.js that referenced this issue Aug 8, 2018
@hirako2000
Rename start to play, adjusts doc, example and types sasha240100#21
b2d8c83
sasha240100 added a commit that referenced this issue Aug 9, 2018
@sasha240100
Merge pull request #31 from hirako2000/#21
4fe4cae 
PR for #21
@hirako2000
Copy link
Contributor

good to close?

@sasha240100
Copy link
Owner

@hirako2000 yes

@sasha240100 sasha240100 added this to the v0.1.2 milestone Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
v0.1.2
Development

No branches or pull requests
3 participants
@hirako2000 @Kris-B @sasha240100