Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinitely emiting both 'update' and 'complete' events #34

Closed
panstav opened this issue Aug 15, 2018 · 3 comments
Closed

Infinitely emiting both 'update' and 'complete' events #34

panstav opened this issue Aug 15, 2018 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@panstav
Copy link

panstav commented Aug 15, 2018

If you take the example code and run it with @0.1.1 you can see it's infinitely emiting both update and complete events.

Perhaps there's a if (this[SYMBOL_COMPLETED]) return; missing.

At first I wanted to PR a test to ensure that a Between instance that should run once would only emit the complete once and would not emit update afterwards, but was unsuccessful in running the tests locally. Would appreciate some help with that as well.

Thanks

@sasha240100
Copy link
Owner

sasha240100 commented Aug 15, 2018

@panstav Thanks for reporting! The codepen link returns 403 Error however, could you reupload it please?
UPD: Was able to use this link: https://codepen.io/panstav/pen/rrgzWK

@sasha240100 sasha240100 added the bug Something isn't working label Aug 15, 2018
@sasha240100 sasha240100 added this to the v0.1.2 milestone Aug 15, 2018
sasha240100 added a commit that referenced this issue Aug 15, 2018
@sasha240100
Copy link
Owner

Fixed in 043a9fa.

@panstav
Copy link
Author

panstav commented Aug 15, 2018

Perfect! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants