Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for #28 - Typings #29

Merged
merged 1 commit into from
Aug 5, 2018
Merged

PR for #28 - Typings #29

merged 1 commit into from
Aug 5, 2018

Conversation

hirako2000
Copy link
Contributor

@hirako2000 hirako2000 commented Aug 4, 2018

Adds type definitions for the offered API, also define types for the supported emitted Events and some functions from easing-functions - Also adds some tslint config
#28

…support emitted Events and some functions from easing-functions - Also adds some tslint config
@sasha240100
Copy link
Owner

@hirako2000 Thanks! By the way, should we add unit tests for types? (if there is any way of such)

@sasha240100 sasha240100 merged commit c111310 into sasha240100:master Aug 5, 2018
@hirako2000
Copy link
Contributor Author

hirako2000 commented Aug 5, 2018

Test are there
I don't know whether the build runs them though.

@hirako2000 hirako2000 deleted the #28 branch August 5, 2018 09:05
@sasha240100
Copy link
Owner

@hirako2000 Looks like it doesn't

@sasha240100 sasha240100 added this to the v0.1.2 milestone Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants