remove omitempty tag from temperature fields (#333)

[vvatanabe]

I confirmed the OpenAI API documentation. The default value for temperature is 1. The temperature field of the request structure was given an omitempty tag, so a value of 0 was removed from the request parameter. It would be better to remove the omitempty tag so that 0 can be used.

Oops, removing the omitempty tag changes the default value in this client library.
I thought it would be better to change the temperature type to pointer(*float32). But that is BREAKING CHANGES.

Refs:

• https://platform.openai.com/docs/api-reference/chat/create#chat/create-temperature
• https://platform.openai.com/docs/api-reference/completions/create#completions/create-temperature
• https://platform.openai.com/docs/api-reference/edits/create#edits/create-temperature

Note: For audio api only, the default value for temperature is 0.
Refs: https://platform.openai.com/docs/api-reference/audio/create

[codecov]

Codecov Report

Merging #334 (7977a70) into master (61ba5f3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #334   +/-   ##
=======================================
  Coverage   92.45%   92.45%           
=======================================
  Files          18       18           
  Lines         636      636           
=======================================
  Hits          588      588           
  Misses         35       35           
  Partials       13       13           

Impacted Files	Coverage Δ
chat.go	100.00% <ø> (ø)
completion.go	100.00% <ø> (ø)
edits.go	100.00% <ø> (ø)

[vvatanabe]

Oops, removing the omitempty tag changes the default value in this client library.

I thought it would be better to change the temperature type to pointer(*float32). But that is BREAKING CHANGES.

[vvatanabe]

Wait for a major version upgrade.

[sashabaranov]

Hey, thank you for the PR, that's the oldest open issue we have in this repo #9

So the current behavior is that if you want to default to OpenAI's temperature default, you don't include the temperature parameter in the request. However, you can't set the temperature to exactly zero, only to some small non-zero float value.

I'm not sure there's a strong argument to break the current behavior, given that there are a lot of users relying on the current implementation.

[sashabaranov]

@vvatanabe I like the v2 idea, I guess we should discuss on what highest ROI breakages might be