fix error 400 during function call

[mehulgohil]

Describe the change
Added omitempty as json tag for properties field

Describe your solution
Was getting error 400 while calling open api function call. So have added omitempty json tag. As properties was going as null

Tests
Fixed tests accordingly

Issue: #432

[codecov]

Codecov Report

Merging #433 (127c95d) into master (f028c28) will not change coverage.
The diff coverage is n/a.

❗ Current head 127c95d differs from pull request most recent head 6f7ec02. Consider uploading reports for the commit 6f7ec02 to get more accurate results

@@           Coverage Diff           @@
##           master     #433   +/-   ##
=======================================
  Coverage   97.02%   97.02%           
=======================================
  Files          17       17           
  Lines         705      705           
=======================================
  Hits          684      684           
  Misses         15       15           
  Partials        6        6           

[vvatanabe]

@mehulgohil Thanks for PR. This issue has already been Fixed in #431. This commit has not yet been tagged for release.

[vvatanabe]

@mehulgohil Please try running the following code using the latest go-openai. (Commit ID: f028c28).

package main

import (
	"context"
	"encoding/json"
	"fmt"
	"os"

	"github.com/sashabaranov/go-openai"
	"github.com/sashabaranov/go-openai/jsonschema"
)

func main() {
	client := openai.NewClient(os.Getenv("OPENAI_API_KEY"))
	resp, err := client.CreateChatCompletion(
		context.Background(),
		openai.ChatCompletionRequest{
			Model: openai.GPT3Dot5Turbo,
			Messages: []openai.ChatCompletionMessage{
				{
					Role:    openai.ChatMessageRoleUser,
					Content: "What is the weather like in Boston?",
				},
			},
			Functions: []openai.FunctionDefinition{{
				Name: "get_current_weather",
				Parameters: &jsonschema.Definition{
					Type: jsonschema.Object,
					Properties: map[string]jsonschema.Definition{
						"location": {
							Type:        jsonschema.String,
							Description: "The city and state, e.g. San Francisco, CA",
						},
						"unit": {
							Type: jsonschema.String,
							Enum: []string{"celsius", "fahrenheit"},
						},
					},
					Required: []string{"location"},
				},
			}},
		},
	)
	if err != nil {
		fmt.Printf("Completion error: %v\n", err)
		return
	}
	respJson, _ := json.Marshal(resp)
	fmt.Println(string(respJson))
}

[mehul-gohil]

@vvatanabe I did try with latest commit only

[mehulgohil]

@vvatanabe I see the difference here
I was not using the &operator

Parameters: &jsonschema.Definition{}

[mehulgohil]

@vvatanabe I have updated the readme file example for function call

[vvatanabe]

@mehulgohil I get it, MarshalJSON() is a receiver, so it looks like MarshalJSON() won't execute unless you pass it a pointer.

func (d *Definition) MarshalJSON() ([]byte, error)

[vvatanabe]

@mehulgohil I made a PR to support both pointers and values. Please check #434

[mehulgohil]

This makes sense, thanks @vvatanabe

[vvatanabe]

@mehulgohil Merged #434

[ttdias25]

@mehulgohil Please try running the following code using the latest go-openai. (Commit ID: f028c28).

package main

import (
	"context"
	"encoding/json"
	"fmt"
	"os"

	"github.com/sashabaranov/go-openai"
	"github.com/sashabaranov/go-openai/jsonschema"
)

func main() {
	client := openai.NewClient(os.Getenv("OPENAI_API_KEY"))
	resp, err := client.CreateChatCompletion(
		context.Background(),
		openai.ChatCompletionRequest{
			Model: openai.GPT3Dot5Turbo,
			Messages: []openai.ChatCompletionMessage{
				{
					Role:    openai.ChatMessageRoleUser,
					Content: "What is the weather like in Boston?",
				},
			},
			Functions: []openai.FunctionDefinition{{
				Name: "get_current_weather",
				Parameters: &jsonschema.Definition{
					Type: jsonschema.Object,
					Properties: map[string]jsonschema.Definition{
						"location": {
							Type:        jsonschema.String,
							Description: "The city and state, e.g. San Francisco, CA",
						},
						"unit": {
							Type: jsonschema.String,
							Enum: []string{"celsius", "fahrenheit"},
						},
					},
					Required: []string{"location"},
				},
			}},
		},
	)
	if err != nil {
		fmt.Printf("Completion error: %v\n", err)
		return
	}
	respJson, _ := json.Marshal(resp)
	fmt.Println(string(respJson))
}

I tried this exact example and the response (response.Choices[0].Message.Content) was empty, any idea?