Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes omitempty from stream chatcompletionrequest #436

Closed
wants to merge 3 commits into from

Conversation

odannyc
Copy link

@odannyc odannyc commented Jul 11, 2023

Describe the change

More info in this issue: #435
This PR removes the omitempty json tag from the ChatCompletionRequest.

Issue: #435

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #436 (6c16621) into master (c3b2451) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   97.02%   97.02%           
=======================================
  Files          17       17           
  Lines         705      705           
=======================================
  Hits          684      684           
  Misses         15       15           
  Partials        6        6           
Impacted Files Coverage Δ
audio.go 88.15% <ø> (ø)
chat.go 100.00% <ø> (ø)
client.go 100.00% <ø> (ø)
stream_reader.go 100.00% <ø> (ø)
error.go 100.00% <100.00%> (ø)

@odannyc
Copy link
Author

odannyc commented Jul 11, 2023

Closing due to commits made to the upstream fork that weren't meant to go here.

@odannyc odannyc closed this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant