Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add SystemFingerprint for chat completion stream response #716

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

winrey
Copy link
Contributor

@winrey winrey commented Apr 18, 2024

Describe the change
Add the SystemFingerprint for the chat completions stream response

Provide OpenAI documentation link
https://platform.openai.com/docs/api-reference/chat/streaming#chat/streaming-system_fingerprint

Describe your solution
Add a prop in structure ChatCompletionStreamResponse

Tests
Modify test case on chat_stream_test.go

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (774fc9d) to head (46c118a).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
+ Coverage   98.46%   98.67%   +0.21%     
==========================================
  Files          24       24              
  Lines        1364     1134     -230     
==========================================
- Hits         1343     1119     -224     
+ Misses         15        9       -6     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@winrey winrey changed the title Add SystemFingerprint for chat completion stream response chore: add SystemFingerprint for chat completion stream response Apr 18, 2024
Copy link
Owner

@sashabaranov sashabaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍🏻

@sashabaranov sashabaranov merged commit 2d58f8f into sashabaranov:master Apr 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants