Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for word-level audio transcription timestamp granularity #733

Merged
merged 2 commits into from
May 7, 2024

Conversation

agcom
Copy link
Contributor

@agcom agcom commented May 5, 2024

Describe the change
Add support for word-level audio transcription timestamp granularity.

Provide OpenAI documentation link

Describe your solution
Added AudioRequest.TimestampGranularities and AudioResponse.Words fields.

Tests
Filled AudioRequest.TimestampGranularities field in the existing tests' audio requests.

Additional context

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (774fc9d) to head (456ceba).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
+ Coverage   98.46%   98.68%   +0.22%     
==========================================
  Files          24       24              
  Lines        1364     1140     -224     
==========================================
- Hits         1343     1125     -218     
+ Misses         15        9       -6     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agcom
Copy link
Contributor Author

agcom commented May 5, 2024

I would have proposed separating transcription and translation request/response types, but that would have been a breaking change.

@sashabaranov
Copy link
Owner

Thank you for working on this!

@sashabaranov
Copy link
Owner

@agcom the PR looks good to me in its current state!

I would have proposed separating transcription and translation request/response types, but that would have been a breaking change.

We can discuss it in a separate PR, also totally open to look at a sketch of how this might look like 🙌🏻

@agcom agcom marked this pull request as ready for review May 6, 2024 13:31
@agcom
Copy link
Contributor Author

agcom commented May 6, 2024

@sashabaranov alright then, ready to review. I just wanted to test it out in our development server before marking it for review (did it, and it works fine).

We can discuss it in a separate PR, also totally open to look at a sketch of how this might look like 🙌🏻

May god bless me with more code refactoring tasks so I would work on this 😄.

@sashabaranov sashabaranov merged commit 3334a9c into sashabaranov:master May 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants