Fix integration test #762
Merged
Fix integration test #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAdamSmith
force-pushed
the
fix-integration-test
branch
2 times, most recently
from
3583067
to
2186686
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #762 +/- ##
==========================================
+ Coverage 98.46% 98.68% +0.22%
==========================================
Files 24 24
Lines 1364 1140 -224
==========================================
- Hits 1343 1125 -218
+ Misses 15 9 -6
Partials 6 6 ☔ View full report in Codecov by Sentry. |
moved completion stream testing to seperate function added NoErrorF fixes nil pointer reference on stream object
TheAdamSmith
force-pushed
the
fix-integration-test
branch
from
2186686
to
7823611
Compare
TheAdamSmith
commented
Jun 5, 2024
| @@ -16,7 +16,7 @@ var ErrVectorLengthMismatch = errors.New("vector length mismatch") | |||
| type EmbeddingModel string | |||
|
|
|||
| const ( | |||
| // Deprecated: The following block will be shut down on January 04, 2024. Use text-embedding-ada-002 instead. | |||
| // Deprecated: The following block is shut down. Use text-embedding-ada-002 instead. | |||
There was a problem hiding this comment.
IMO these should just be removed now that they are shutdown, but wasn't sure that would cause issues
sashabaranov
approved these changes
Jun 13, 2024
This was referenced Jun 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Updates the integration tests to the updated models so that the tests will work. Updated models based off of the Openai recommended upgrades https://platform.openai.com/docs/deprecations
Provide OpenAI documentation link
https://platform.openai.com/docs/deprecations
Describe your solution
Refactored the completion streaming test into its own class and added a
NoErrorFcheck. This fixes the nil pointer dereference error when this test fails and allows the other tests to keep running.Updated the models the tests were using
Tests
Additional context
#761
Issue: #761