Change Definition struct 'Type' field to support multiple data types … #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for union parameters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #833 +/- ##
==========================================
+ Coverage 98.46% 99.01% +0.55%
==========================================
Files 24 26 +2
Lines 1364 1418 +54
==========================================
+ Hits 1343 1404 +61
+ Misses 15 8 -7
Partials 6 6 ☔ View full report in Codecov by Sentry. |
|
@sashabaranov works, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
This PR modifies the Definition struct by updating the Type field to support multiple data types. This change is intended to facilitate the use of union types for parameters, allowing schemas to accommodate a broader range of data types as specified by the OpenAI documentation.
Provide OpenAI documentation link
https://platform.openai.com/docs/guides/structured-outputs/supported-schemas
Describe your solution
To address the need for supporting union types in schema definitions, the Type field in the Definition struct has been updated to allow for multiple data types. This change enables developers to define schemas that can handle a variety of data types, offering more flexibility in schema design.
Tests
Tested manually for both types (existing single type format and new multiple format)
Issue: #832