Merge pull request #75 from sashamelentyev/refactor/test

refactor: set flags in loop

pkg/analyzer/analyzer_test.go

@@ -9,6 +9,22 @@ import (
 )
 
 func TestUseStdlibVars(t *testing.T) {
+	a := analyzer.New()
+
+	for _, flag := range []string{
+		analyzer.TimeWeekdayFlag,
+		analyzer.TimeMonthFlag,
+		analyzer.TimeLayoutFlag,
+		analyzer.CryptoHashFlag,
+		analyzer.RPCDefaultPathFlag,
+		analyzer.OSDevNullFlag,
+		analyzer.SQLIsolationLevelFlag,
+		analyzer.TLSSignatureSchemeFlag,
+		analyzer.ConstantKindFlag,
+	} {
+		mustNil(t, a.Flags.Set(flag, "true"))
+	}
+
 	pkgs := []string{
 		"a/crypto",
 		"a/http",
@@ -20,24 +36,13 @@ func TestUseStdlibVars(t *testing.T) {
 		"a/constant",
 	}
 
-	a := analyzer.New()
-
-	mustNil(t, a.Flags.Set(analyzer.TimeWeekdayFlag, "true"))
-	mustNil(t, a.Flags.Set(analyzer.TimeMonthFlag, "true"))
-	mustNil(t, a.Flags.Set(analyzer.TimeLayoutFlag, "true"))
-	mustNil(t, a.Flags.Set(analyzer.CryptoHashFlag, "true"))
-	mustNil(t, a.Flags.Set(analyzer.RPCDefaultPathFlag, "true"))
-	mustNil(t, a.Flags.Set(analyzer.OSDevNullFlag, "true"))
-	mustNil(t, a.Flags.Set(analyzer.SQLIsolationLevelFlag, "true"))
-	mustNil(t, a.Flags.Set(analyzer.TLSSignatureSchemeFlag, "true"))
-	mustNil(t, a.Flags.Set(analyzer.ConstantKindFlag, "true"))
-
 	analysistest.Run(t, analysistest.TestData(), a, pkgs...)
 }
 
 func mustNil(t *testing.T, err error) {
 	t.Helper()
+
 	if err != nil {
-		t.Error(err)
+		t.Fatal(err)
 	}
 }