Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(job-state): added session state check to doPoll func #832

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

YuryShkoda
Copy link
Member

@YuryShkoda YuryShkoda commented Sep 11, 2023

Issue

Sometimes SAS API returns the job state running when the parent session is not in a running state.

Intent

  • Periodically (every 10th job state poll) check parent session state.

Implementation

  • Added parent session state check to doPoll function located at src/api/viya/pollJobState.ts.
  • Adjusted src/api/viya/executeOnComputeApi.ts
  • Refactored src/SessionManager.ts.
  • Adjusted existing unit tests and covered new functionality.
  • Updated unit test threshold.

Checks

No PR (that involves a non-trivial code change) should be merged, unless all items below are confirmed! If an urgent fix is needed - use a tar file.

  • Unit tests coverage has been increased and a new threshold is set.
  • All sasjs-cli unit tests are passing (npm test).
  • (CI Runs this) All sasjs-tests are passing. If you want to run it manually (instructions available here).
  • Data Controller builds and is functional on both SAS 9 and Viya

@medjedovicm medjedovicm merged commit 5dfee30 into master Sep 11, 2023
1 of 2 checks passed
@medjedovicm medjedovicm deleted the parent-session-state-check branch September 11, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants