Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(poll-job-state): fixed checking session state #833

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

YuryShkoda
Copy link
Member

Issue

Parent session may be in a not healthy state (running or idle) while checking SAS job state.

Intent

  • Add idle as a healthy parent session state.

Implementation

  • Added isSessionStatesHealthy utility to src/api/viya/pollJobState.ts.
  • Adjusted unit tests covering doPoll function.

Checks

No PR (that involves a non-trivial code change) should be merged, unless all items below are confirmed! If an urgent fix is needed - use a tar file.

  • Unit tests coverage has been increased and a new threshold is set.
  • All sasjs-cli unit tests are passing (npm test).
  • (CI Runs this) All sasjs-tests are passing. If you want to run it manually (instructions available here).
  • Data Controller builds and is functional on both SAS 9 and Viya

@YuryShkoda YuryShkoda merged commit 10da691 into master Sep 15, 2023
1 of 2 checks passed
@YuryShkoda YuryShkoda deleted the parent-session-state-check branch September 15, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants