Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth-manager): fixed redirectedLoginUrl #834

Merged
merged 4 commits into from
Feb 19, 2024
Merged

fix(auth-manager): fixed redirectedLoginUrl #834

merged 4 commits into from
Feb 19, 2024

Conversation

YuryShkoda
Copy link
Member

@YuryShkoda YuryShkoda commented Feb 19, 2024 •
edited
Loading

Issue

  • The SASLogon URL is incorrect when the login mechanism is Redirected.

Intent

  • Add server URL to redirected login URL.

Implementation

  • Added serverUrl to redirectedLoginUrl in src/auth/AuthManager.ts.

Checks

No PR (that involves a non-trivial code change) should be merged, unless all items below are confirmed! If an urgent fix is needed - use a tar file.

  • Unit tests coverage has been increased and a new threshold is set.
  • All sasjs-cli unit tests are passing (npm test).
  • (CI Runs this) All sasjs-tests are passing. If you want to run it manually (instructions available here).
  • Data Controller builds and is functional on both SAS 9 and Viya

@YuryShkoda YuryShkoda marked this pull request as ready for review February 19, 2024 12:27
@YuryShkoda YuryShkoda merged commit 4c45119 into master Feb 19, 2024
1 check failed
@YuryShkoda YuryShkoda deleted the redirectLogin-fix branch February 19, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medjedovicm medjedovicm medjedovicm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuryShkoda @medjedovicm @Yury4GL