Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job command improvements #1376

Merged
merged 5 commits into from
Sep 15, 2023
Merged

Job command improvements #1376

merged 5 commits into from
Sep 15, 2023

Conversation

YuryShkoda
Copy link
Member

@YuryShkoda YuryShkoda commented Sep 15, 2023

Issue

  • Bleached verbose mode wasn't working when set through the environment variable.
  • @sasjs/adapter was treating idle parent session state as not healthy while polling the job state.

Intent

  • Bump @sasjs/adapter.
  • Fix verbose mode while running sasjs job execute command.
  • Refactor @sasjs/adapter instantiation.

Implementation

  • Fixed getVerbose function in src/commands/job/jobCommand.ts.
  • Adjusted unit tests related to sasjs job execute command.
  • Fixed createEnvFileForViya utility.
  • Used getSASjs utility to get an instance of @sasjs/adapter instead of instantiating it manually .

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • Unit tests coverage has been increased and a new threshold is set.
  • All CI checks are green.
  • Development comments have been added or updated.
  • Development documentation coverage has been increased and a new threshold is set.
  • Reviewer is assigned.

Reviewer checks

  • Any new code is documented.

@github-actions
Copy link

github-actions bot commented Sep 15, 2023

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 73.56% 3303/4490
🟡 Branches 60.55% 1311/2165
🟡 Functions 73.57% 668/908
🟢 Lines 82.59% 8432/10209

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from f45a2fc

medjedovicm
medjedovicm previously approved these changes Sep 15, 2023
@YuryShkoda YuryShkoda merged commit 580a6a3 into main Sep 15, 2023
2 checks passed
@YuryShkoda YuryShkoda deleted the job-command-improvements branch September 15, 2023 11:30
@github-actions
Copy link

🎉 This PR is included in version 4.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants