Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable DRIVE_LOCATION setting for deploying multiple instances #311

Merged
merged 2 commits into from
Nov 2, 2022
Merged

feat: Enable DRIVE_LOCATION setting for deploying multiple instances #311

merged 2 commits into from
Nov 2, 2022

Conversation

sabhas
Copy link
Member

@sabhas sabhas commented Nov 2, 2022

Issue

closes #310

Intent

  • add new env variable DRIVE_LOCATION for drive location
  • With this new variable we can run multiple instances of sasjs server with same drive on shared location

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • Reviewer is assigned.

@allanbowe allanbowe merged commit 337e2eb into main Nov 2, 2022
@allanbowe allanbowe deleted the issue-310 branch November 2, 2022 15:19
@sasjsbot
Copy link

sasjsbot commented Nov 2, 2022

🎉 This PR is included in version 0.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanbowe allanbowe allanbowe approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable DRIVE_LOCATION setting for deploying multiple instances of SASjs Server
3 participants
@sabhas @sasjsbot @allanbowe