Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SAS log #351

Merged
merged 17 commits into from
Apr 28, 2023
Merged

Improve SAS log #351

merged 17 commits into from
Apr 28, 2023

Conversation

YuryShkoda
Copy link
Member

@YuryShkoda YuryShkoda commented Apr 11, 2023

Issue

Closes #346

Intent

  • Display error and warning icons in Log tab if the runtime is SAS.
  • Display error/warning tree at the top of the log if the runtime is SAS.
  • Change error/warning font color within the log if the runtime is SAS.

Implementation

  • Added web/src/containers/Studio/internal/components/log/logComponent.tsx.
  • Added web/src/containers/Studio/internal/components/log/logTabWithIcons.tsx.
  • Added web/src/utils/log.ts.

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • Reviewer is assigned.

@YuryShkoda YuryShkoda requested a review from sabhas April 11, 2023 11:35
@allanbowe allanbowe merged commit df5d40b into main Apr 28, 2023
@allanbowe allanbowe deleted the issue-346 branch April 28, 2023 09:29
@sasjsbot
Copy link

🎉 This PR is included in version 0.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show ERRORs and WARNINGs in SAS Log
4 participants