Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API scripts #366

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix API scripts #366

wants to merge 5 commits into from

Conversation

YuryShkoda
Copy link
Member

Issue

  • cp command is not supported by Windows Command Prompt (cmd.exe).
  • npm reported vulnerability in jsonwebtoken.

Intent

  • Improve api scripts to make it work in all shells.
  • Fix vulnerable dependency.

Implementation

  • Used cpr package to copy folders within api scripts.
  • Bumped version of jsonwebtoken.
  • Regenerated swagger.yaml.

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • Reviewer is assigned.

@YuryShkoda
Copy link
Member Author

Unit tests covering api are failing due to #367 issue.

@YuryShkoda YuryShkoda changed the title Cpr fix Fix API scripts Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants