Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter device by name / enable unit updating #4

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Conversation

dearmash
Copy link
Contributor

Updated the bluetooth scanning to only show devices named 'LYWSD02' to remove unwanted devices
Updated updateUnit to actually read and write to set the appropriate values based on discussion on JsBergbau/MiTemperature2#1 (comment)

Updated the bluetooth scanning to only show devices named 'LYWSD02' to remove unwanted devices
Updated updateUnit to actually read and write to set the appropriate values based on discussion on JsBergbau/MiTemperature2#1 (comment)
@dearmash
Copy link
Contributor Author

dearmash commented Jun 17, 2021

First, thanks a million for writing this. I've had this device for a little while, but for the life of me couldn't configure it from macOS via command line / python. Instead I had to ssh into a raspberry pi and all sorts of complicated nonsense. This repo is a huge simplification.

The only thing missing was to get the C/F switch working, I noticed you had the stubs in there, so I just massaged it to work I think as intended (read the existing value to log out the different new value). The values also didn't match the other values I found online 'documenting' this, after changing that, it works like a charm.

The part about filtering devices, I could take it or leave it. I have it on my own copy for convenience, figured I'd share at least. Can take it out if it's not wanted.

*edit: Note, I'm pushing here because it seems per https://www.adafruit.com/product/5023 this might become a 'canonical' location for people to find and use. It's how I discovered this. Congrats.

@saso5 saso5 merged commit 1da4346 into saso5:master Jun 29, 2021
@saso5
Copy link
Owner

saso5 commented Jun 29, 2021

I apologies for not getting back to you sooner. First of all, thank you for this MR!
I've tried the C/F switch but it didn't work for me and as I use C, didn't bother with it.
Device filter is also a nice improvement 👌

Had no idea that adafruit was linking to my code. Nice :)
Tnx again for the MR and all the info.

@saso5
Copy link
Owner

saso5 commented Aug 13, 2021

FYI: I had to reverte the device filtering to also support MHO-C303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants