Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node 20 #10

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Update to node 20 #10

merged 1 commit into from
Mar 12, 2024

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Mar 12, 2024

Copy link
Contributor

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nex3 nex3 merged commit 4563b45 into sass:main Mar 12, 2024
@ntkme ntkme deleted the node-20 branch March 12, 2024 21:21
@ntkme
Copy link
Contributor Author

ntkme commented Mar 12, 2024

@nex3 Since all other repos are referring this repo as @v1, we probably should re-tag v1? Or alternatively we can switch to @main in other repo.

@ntkme
Copy link
Contributor Author

ntkme commented Jul 24, 2024

@nex3 Pinging again as we can still see tons of deprecation warnings on dart-sass CI.

We need to do one of the following:

  1. Delete and retag v1 with current commit on main branch.
  2. Delete tag v1 and rename branch main to branch v1.
  3. Tag v2 and update all other repos with clone-linked-repo@v2.
  4. Update all other repos with clone-linked-repo@main.

Any preference?

@ntkme
Copy link
Contributor Author

ntkme commented Jul 24, 2024

@nex3
Copy link
Contributor

nex3 commented Jul 26, 2024

Sorry I missed this! I've put out #11 which should avoid this problem in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants