Skip to content

Commit

Permalink
[Shared Resources] dart-sass implementation (#2134)
Browse files Browse the repository at this point in the history
Co-authored-by: James Stuckey Weber <jamesnw@gmail.com>
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
  • Loading branch information
3 people authored Jan 18, 2024
1 parent 0d91c92 commit 076414d
Show file tree
Hide file tree
Showing 8 changed files with 149 additions and 4 deletions.
16 changes: 15 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,18 @@
## 1.69.8
## 1.70.0

### JavaScript API

* Add a `sass.initCompiler()` function that returns a `sass.Compiler` object
which supports `compile()` and `compileString()` methods with the same API as
the global Sass object. On the Node.js embedded host, each `sass.Compiler`
object uses a single long-lived subprocess, making compiling multiple
stylesheets much more efficient.

* Add a `sass.initAsyncCompiler()` function that returns a `sass.AsyncCompiler`
object which supports `compileAsync()` and `compileStringAsync()` methods with
the same API as the global Sass object. On the Node.js embedded host, each
`sass.AsynCompiler` object uses a single long-lived subprocess, making
compiling multiple stylesheets much more efficient.

### Embedded Sass

Expand Down
6 changes: 6 additions & 0 deletions lib/src/js.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import 'js/exception.dart';
import 'js/exports.dart';
import 'js/compile.dart';
import 'js/compiler.dart';
import 'js/legacy.dart';
import 'js/legacy/types.dart';
import 'js/legacy/value.dart';
Expand All @@ -24,6 +25,11 @@ void main() {
exports.compileAsync = allowInteropNamed('sass.compileAsync', compileAsync);
exports.compileStringAsync =
allowInteropNamed('sass.compileStringAsync', compileStringAsync);
exports.initCompiler = allowInteropNamed('sass.initCompiler', initCompiler);
exports.initAsyncCompiler =
allowInteropNamed('sass.initAsyncCompiler', initAsyncCompiler);
exports.Compiler = compilerClass;
exports.AsyncCompiler = asyncCompilerClass;
exports.Value = valueClass;
exports.SassBoolean = booleanClass;
exports.SassArgumentList = argumentListClass;
Expand Down
113 changes: 113 additions & 0 deletions lib/src/js/compiler.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
// Copyright 2024 Google LLC. Use of this source code is governed by an
// MIT-style license that can be found in the LICENSE file or at
// https://opensource.org/licenses/MIT.

import 'dart:js_util';

import 'package:async/async.dart';
import 'package:node_interop/js.dart';

import 'compile.dart';
import 'compile_options.dart';
import 'reflection.dart';
import 'utils.dart';

/// The Dart Compiler class.
class Compiler {
/// A flag signifying whether the instance has been disposed.
bool _disposed = false;

/// Checks if `dispose()` has been called on this instance, and throws an
/// error if it has. Used to verify that compilation methods are not called
/// after disposal.
void _throwIfDisposed() {
if (_disposed) {
jsThrow(JsError('Compiler has already been disposed.'));
}
}
}

/// The Dart Async Compiler class.
class AsyncCompiler extends Compiler {
/// A set of all compilations, tracked to ensure all compilations complete
/// before async disposal resolves.
final FutureGroup<void> compilations = FutureGroup();

/// Adds a compilation to the FutureGroup.
void addCompilation(Promise compilation) {
Future<dynamic> comp = promiseToFuture(compilation);
var wrappedComp = comp.catchError((err) {
/// Ignore errors so FutureGroup doesn't close when a compilation fails.
});
compilations.add(wrappedComp);
}
}

/// The JavaScript `Compiler` class.
final JSClass compilerClass = () {
var jsClass = createJSClass(
'sass.Compiler',
(Object self) => {
jsThrow(JsError(("Compiler can not be directly constructed. "
"Please use `sass.initCompiler()` instead.")))
});

jsClass.defineMethods({
'compile': (Compiler self, String path, [CompileOptions? options]) {
self._throwIfDisposed();
return compile(path, options);
},
'compileString': (Compiler self, String source,
[CompileStringOptions? options]) {
self._throwIfDisposed();
return compileString(source, options);
},
'dispose': (Compiler self) {
self._disposed = true;
},
});

getJSClass(Compiler()).injectSuperclass(jsClass);
return jsClass;
}();

Compiler initCompiler() => Compiler();

/// The JavaScript `AsyncCompiler` class.
final JSClass asyncCompilerClass = () {
var jsClass = createJSClass(
'sass.AsyncCompiler',
(Object self) => {
jsThrow(JsError(("AsyncCompiler can not be directly constructed. "
"Please use `sass.initAsyncCompiler()` instead.")))
});

jsClass.defineMethods({
'compileAsync': (AsyncCompiler self, String path,
[CompileOptions? options]) {
self._throwIfDisposed();
var compilation = compileAsync(path, options);
self.addCompilation(compilation);
return compilation;
},
'compileStringAsync': (AsyncCompiler self, String source,
[CompileStringOptions? options]) {
self._throwIfDisposed();
var compilation = compileStringAsync(source, options);
self.addCompilation(compilation);
return compilation;
},
'dispose': (AsyncCompiler self) {
self._disposed = true;
return futureToPromise((() async {
self.compilations.close();
await self.compilations.future;
})());
}
});

getJSClass(AsyncCompiler()).injectSuperclass(jsClass);
return jsClass;
}();

Promise initAsyncCompiler() => futureToPromise((() async => AsyncCompiler())());
4 changes: 4 additions & 0 deletions lib/src/js/exports.dart
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ class Exports {
external set compileStringAsync(Function function);
external set compile(Function function);
external set compileAsync(Function function);
external set initCompiler(Function function);
external set initAsyncCompiler(Function function);
external set Compiler(JSClass function);
external set AsyncCompiler(JSClass function);
external set info(String info);
external set Exception(JSClass function);
external set Logger(LoggerNamespace namespace);
Expand Down
4 changes: 4 additions & 0 deletions pkg/sass_api/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 9.3.0

* No user-visible changes.

## 9.2.7

* No user-visible changes.
Expand Down
4 changes: 2 additions & 2 deletions pkg/sass_api/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ name: sass_api
# Note: Every time we add a new Sass AST node, we need to bump the *major*
# version because it's a breaking change for anyone who's implementing the
# visitor interface(s).
version: 9.2.7
version: 9.3.0
description: Additional APIs for Dart Sass.
homepage: https://github.com/sass/dart-sass

environment:
sdk: ">=3.0.0 <4.0.0"

dependencies:
sass: 1.69.7
sass: 1.70.0

dev_dependencies:
dartdoc: ^6.0.0
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: sass
version: 1.69.8-dev
version: 1.70.0
description: A Sass implementation in Dart.
homepage: https://github.com/sass/dart-sass

Expand Down
4 changes: 4 additions & 0 deletions tool/grind.dart
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ void main(List<String> args) {
'compileAsync',
'compileString',
'compileStringAsync',
'initCompiler',
'initAsyncCompiler',
'Compiler',
'AsyncCompiler',
'Logger',
'SassArgumentList',
'SassBoolean',
Expand Down

0 comments on commit 076414d

Please sign in to comment.