Skip to content

Commit

Permalink
Properly override the sass-parser dependency on sass during release (#…
Browse files Browse the repository at this point in the history
…2487)

Previously we were loading the version variable after running `npm
install sass@$version`, which caused the local path dependency not to
be overwritten and consequently made the sass-parser package
impossible to install.
  • Loading branch information
nex3 authored Jan 13, 2025
1 parent adb7016 commit 8818d93
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 10 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,11 @@ jobs:
check-latest: true
registry-url: 'https://registry.npmjs.org'

- name: Get version
id: version
run: |
echo "version=$(jq .version pkg/sass-parser/package.json)" | tee --append "$GITHUB_OUTPUT"
# The repo package has a file dependency, but the released version needs
# a real dependency on the released version of Sass.
- run: npm install sass@${{ steps.version.outputs.version }}
Expand All @@ -137,10 +142,6 @@ jobs:
NODE_AUTH_TOKEN: '${{ secrets.NPM_TOKEN }}'
working-directory: pkg/sass-parser/

- name: Get version
id: version
run: |
echo "version=$(jq .version pkg/sass-parser/package.json)" | tee --append "$GITHUB_OUTPUT"
- run: git tag sass-parser/${{ steps.version.outputs.version }}
- run: git push --tag

Expand Down
10 changes: 5 additions & 5 deletions pkg/sass-parser/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
## 0.4.9

* No user-visible changes.
* Add support for parsing the `@include` rule.

## 0.4.8
* Add support for parsing declarations.

Add support for parsing the `@include` rule.
## 0.4.8

Add support for parsing the `@mixin` rule.
* Add support for parsing the `@mixin` rule.

Add support for parsing the `@return` rule.
* Add support for parsing the `@return` rule.

## 0.4.7

Expand Down
2 changes: 1 addition & 1 deletion pkg/sass-parser/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
},
"dependencies": {
"postcss": ">=8.4.41 <8.5.0",
"sass": "file:../../build/npm"
"sass": "^1.83.1"
},
"devDependencies": {
"@types/jest": "^29.5.12",
Expand Down

0 comments on commit 8818d93

Please sign in to comment.