Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks: Record Dart VM time with JIT'd/warm code #16

Open
matanlurey opened this issue Nov 1, 2016 · 2 comments
Open

Benchmarks: Record Dart VM time with JIT'd/warm code #16

matanlurey opened this issue Nov 1, 2016 · 2 comments

Comments

@matanlurey
Copy link
Contributor

At least internally, we spin up a worker and use it for incremental rebuilds. This means the code/snapshot is already loaded, already JITd, and kept warm for the development cycle. This is more likely than spinning up to do a one-time build and closing.

@nex3
Copy link
Contributor

nex3 commented Nov 1, 2016

I'm skeptical that it's more likely—I think most users of the Dart VM version will run it from the CLI rather than setting up a Dart code harness for it. Maybe once we have some watcher functionality this will be more relevant?

I'm not opposed to adding this to the performance document, but I don't have time for it personally.

@matanlurey
Copy link
Contributor Author

matanlurey commented Nov 1, 2016

I don't mind helping here! Internally and with Bazel we'd have it as a worker, so I can contribute.

Edit:

@nex3 Would you prefer a separate repository for Bazel rules and a worker implementation? i.e. dart-sass-bazel, or just part of this repository? I can link you internally to what it would look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants