Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running Dart Sass in QuickJS? #2212

Closed
wch opened this issue Apr 9, 2024 · 4 comments
Closed

Running Dart Sass in QuickJS? #2212

wch opened this issue Apr 9, 2024 · 4 comments

Comments

@wch
Copy link

wch commented Apr 9, 2024

I'm not sure where the best place is to ask this question, so I thought I'd open an issue here.

I'm trying to run Dart Sass using QuickJS. I'm currently trying to a get very minimal program running:

import * as sass from "./sass.default.js";

console.log(sass.info);

console.log(1);

const res = sass.compileString(`
.box {
  width: 10px + 15px;
}
`)

console.log(2);

console.log(res);

This is using the browser build of sass.

When I run this with qjs --module 00test.js it prints out sass.info, but then hangs while running sass.compileString(), using 100% CPU:

❯ qjs --module 00test.js       
dart-sass	1.74.1	(Sass Compiler)	[Dart]
dart2js	3.3.3	(Dart Compiler)	[Dart]
1
^C

Any ideas why this is happening, and if it is feasible to make it work?

For some context, I help maintain the R sass package. It currently uses libsass, but we want to migrate away from it because it is deprecated. I would like to be able to run Dart Sass using QuickJS because QuickJS is simple to build and call from C.

@wch
Copy link
Author

wch commented Apr 9, 2024

One more thing I forgot to mention: this is a gist where I had put my attempt to run Dart Sass in QuickJS. If you just clone the gist and run the command in the README, it should reproduce the issue:
https://gist.github.com/wch/eb453b73981a7f5715903992accca35e

@nex3
Copy link
Contributor

nex3 commented Apr 10, 2024

I'm sorry, I'm not sure what's going on here. It's possible that some of the environment sniffing Sass does to try to determine if it's running in a browser environment is returning inaccurate results here, but it's hard to know for sure without more information. If you can debug into the compiled JS code and figure out where it's stalling out, that would help in figuring out what's going on in more detail.

@wch
Copy link
Author

wch commented Apr 11, 2024

Thanks for the suggestion. I dug into it and found a bug in QuickJS! bellard/quickjs#275

The issue is that when a for loop has a label for the body, a break is supposed to exit the loop, but in QuickJS, it does not. For example, this is supposed to just print 1 and then break out of the loop, but with QuickJS, it prints 1, 2, 3, 4.

for (var i=0; i<4; i++)
label: {
  console.log(i);
  break;
}

This code pattern in question occurs in the sass.dart.js file in A.StylesheetParser0.almostAnyValue$1$omitComments(), and because of the bug in QuickJS, it gets stuck in an infinite loop.

@nex3
Copy link
Contributor

nex3 commented Apr 12, 2024

Thanks for digging that up! I'm going to close this out since it's a bug in quickjs.

@nex3 nex3 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2024
Friendly-users added a commit to Friendly-users/dart-sass that referenced this issue Jun 28, 2024
-----
It is inappropriate to include political and offensive content in public code repositories.

Public code repositories should be neutral spaces for collaboration and community, free from personal or political views that could alienate or discriminate against others. Political content, especially that which targets or disparages minority groups, can be harmful and divisive. It can make people feel unwelcome and unsafe, and it can create a hostile work environment.

Please refrain from adding such content to public code repositories.
---

sass#2000 sass#2001 sass#2002 sass#2003 sass#2004 sass#2005 sass#2006 sass#2007 sass#2008 sass#2009 sass#2010 sass#2011 sass#2012 sass#2013 sass#2014 sass#2015 sass#2016 sass#2017 sass#2018 sass#2019 sass#2020 sass#2021 sass#2022 sass#2023 sass#2024 sass#2025 sass#2026 sass#2027 sass#2028 sass#2029 sass#2030 sass#2031 sass#2032 sass#2033 sass#2034 sass#2035 sass#2036 sass#2037 sass#2038 sass#2039 sass#2040 sass#2041 sass#2042 sass#2043 sass#2044 sass#2045 sass#2046 sass#2047 sass#2048 sass#2049 sass#2050 sass#2051 sass#2052 sass#2053 sass#2054 sass#2055 sass#2056 sass#2057 sass#2058 sass#2059 sass#2060 sass#2061 sass#2062 sass#2063 sass#2064 sass#2065 sass#2066 sass#2067 sass#2068 sass#2069 sass#2070 sass#2071 sass#2072 sass#2073 sass#2074 sass#2075 sass#2076 sass#2077 sass#2078 sass#2079 sass#2080 sass#2081 sass#2082 sass#2083 sass#2084 sass#2085 sass#2086 sass#2087 sass#2088 sass#2089 sass#2090 sass#2091 sass#2092 sass#2093 sass#2094 sass#2095 sass#2096 sass#2097 sass#2098 sass#2099 sass#2100 sass#2101 sass#2102 sass#2103 sass#2104 sass#2105 sass#2106 sass#2107 sass#2108 sass#2109 sass#2110 sass#2111 sass#2112 sass#2113 sass#2114 sass#2115 sass#2116 sass#2117 sass#2118 sass#2119 sass#2120 sass#2121 sass#2122 sass#2123 sass#2124 sass#2125 sass#2126 sass#2127 sass#2128 sass#2129 sass#2130 sass#2131 sass#2132 sass#2133 sass#2134 sass#2135 sass#2136 sass#2137 sass#2138 sass#2139 #2140 sass#2141 sass#2142 sass#2143 sass#2144 sass#2145 sass#2146 sass#2147 sass#2148 sass#2149 sass#2150 sass#2151 sass#2152 sass#2153 sass#2154 sass#2155 sass#2156 sass#2157 sass#2158 sass#2159 sass#2160 sass#2161 sass#2162 sass#2163 sass#2164 sass#2165 sass#2166 sass#2167 sass#2168 sass#2169 sass#2170 sass#2171 sass#2172 sass#2173 sass#2174 sass#2175 sass#2176 sass#2177 sass#2178 sass#2179 sass#2180 sass#2181 sass#2182 sass#2183 sass#2184 sass#2185 sass#2186 sass#2187 sass#2188 sass#2189 sass#2190 sass#2191 sass#2192 sass#2193 sass#2194 sass#2195 sass#2196 sass#2197 sass#2198 sass#2199 sass#2200 sass#2201 sass#2202 sass#2203 sass#2204 sass#2205 sass#2206 sass#2207 sass#2208 sass#2209 sass#2210 sass#2211 sass#2212 sass#2213 sass#2214 sass#2215 #2216 sass#2217 sass#2218 sass#2219 sass#2220 sass#2221 sass#2222 sass#2223 sass#2224 sass#2225 sass#2226 sass#2227 sass#2228 sass#2229 sass#2230 sass#2231 sass#2232 sass#2233 sass#2234 sass#2235 sass#2236 sass#2237 sass#2238 sass#2239 sass#2240 sass#2241 sass#2242 sass#2243 sass#2244 sass#2245 sass#2246 sass#2247 sass#2248 sass#2249 sass#2250 sass#2251 sass#2252 sass#2253 sass#2254 sass#2255 sass#2256 sass#2257 sass#2258 sass#2259 sass#2260 sass#2261 sass#2262 sass#2263 sass#2264 sass#2265 sass#2266 sass#2267 sass#2268 sass#2269 sass#2270
Friendly-users added a commit to Friendly-users/dart-sass that referenced this issue Jul 2, 2024
-----
It is inappropriate to include political and offensive content in public code repositories.

Public code repositories should be neutral spaces for collaboration and community, free from personal or political views that could alienate or discriminate against others. Political content, especially that which targets or disparages minority groups, can be harmful and divisive. It can make people feel unwelcome and unsafe, and it can create a hostile work environment.

Please refrain from adding such content to public code repositories.
---

sass#2000 sass#2001 sass#2002 sass#2003 sass#2004 sass#2005 sass#2006 sass#2007 sass#2008 sass#2009 sass#2010 sass#2011 sass#2012 sass#2013 sass#2014 sass#2015 sass#2016 sass#2017 sass#2018 sass#2019 sass#2020 sass#2021 sass#2022 sass#2023 sass#2024 sass#2025 sass#2026 sass#2027 sass#2028 sass#2029 sass#2030 sass#2031 sass#2032 sass#2033 sass#2034 sass#2035 sass#2036 sass#2037 sass#2038 sass#2039 sass#2040 sass#2041 sass#2042 sass#2043 sass#2044 sass#2045 sass#2046 sass#2047 sass#2048 sass#2049 sass#2050 sass#2051 sass#2052 sass#2053 sass#2054 sass#2055 sass#2056 sass#2057 sass#2058 sass#2059 sass#2060 sass#2061 sass#2062 sass#2063 sass#2064 sass#2065 sass#2066 sass#2067 sass#2068 sass#2069 sass#2070 sass#2071 sass#2072 sass#2073 sass#2074 sass#2075 sass#2076 sass#2077 sass#2078 sass#2079 sass#2080 sass#2081 sass#2082 sass#2083 sass#2084 sass#2085 sass#2086 sass#2087 sass#2088 sass#2089 sass#2090 sass#2091 sass#2092 sass#2093 sass#2094 sass#2095 sass#2096 sass#2097 sass#2098 sass#2099 sass#2100 sass#2101 sass#2102 sass#2103 sass#2104 sass#2105 sass#2106 sass#2107 sass#2108 sass#2109 sass#2110 sass#2111 sass#2112 sass#2113 sass#2114 sass#2115 sass#2116 sass#2117 sass#2118 sass#2119 sass#2120 sass#2121 sass#2122 sass#2123 sass#2124 sass#2125 sass#2126 sass#2127 sass#2128 sass#2129 sass#2130 sass#2131 sass#2132 sass#2133 sass#2134 sass#2135 sass#2136 sass#2137 sass#2138 sass#2139 #2140 sass#2141 sass#2142 sass#2143 sass#2144 sass#2145 sass#2146 sass#2147 sass#2148 sass#2149 sass#2150 sass#2151 sass#2152 sass#2153 sass#2154 sass#2155 sass#2156 sass#2157 sass#2158 sass#2159 sass#2160 sass#2161 sass#2162 sass#2163 sass#2164 sass#2165 sass#2166 sass#2167 sass#2168 sass#2169 sass#2170 sass#2171 sass#2172 sass#2173 sass#2174 sass#2175 sass#2176 sass#2177 sass#2178 sass#2179 sass#2180 sass#2181 sass#2182 sass#2183 sass#2184 sass#2185 sass#2186 sass#2187 sass#2188 sass#2189 sass#2190 sass#2191 sass#2192 sass#2193 sass#2194 sass#2195 sass#2196 sass#2197 sass#2198 sass#2199 sass#2200 sass#2201 sass#2202 sass#2203 sass#2204 sass#2205 sass#2206 sass#2207 sass#2208 sass#2209 sass#2210 sass#2211 sass#2212 sass#2213 sass#2214 sass#2215 #2216 sass#2217 sass#2218 sass#2219 sass#2220 sass#2221 sass#2222 sass#2223 sass#2224 sass#2225 sass#2226 sass#2227 sass#2228 sass#2229 sass#2230 sass#2231 sass#2232 sass#2233 sass#2234 sass#2235 sass#2236 sass#2237 sass#2238 sass#2239 sass#2240 sass#2241 sass#2242 sass#2243 sass#2244 sass#2245 sass#2246 sass#2247 sass#2248 sass#2249 sass#2250 sass#2251 sass#2252 sass#2253 sass#2254 sass#2255 sass#2256 sass#2257 sass#2258 sass#2259 sass#2260 sass#2261 sass#2262 sass#2263 sass#2264 sass#2265 sass#2266 sass#2267 sass#2268 sass#2269 sass#2270 sass#2271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants