Use NoOpImporter for compileString unless url is a file: url
#1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not familiar with dealing with JS Object in Dart so maybe there is a better way to write this. |
|
Is this change necessary? sass/sass-spec#1785 is already passing without it, because if |
|
@nex3 Technically not because it is not going to resolve anyways. It was just for the sake of precisely matching what spec says. |
|
I think it's fine to leave as-is... the spec just mandates observable behavior, not necessarily the structure of code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion: sass/dart-sass-embedded#83 (comment)
Spec: sass/sass#3278